From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Ilias Apalodimas <ilias.apalodimas@linaro•org>, netdev@vger•kernel.org
Cc: jonathan.lemon@gmail•com, lorenzo@kernel•org,
Ilias Apalodimas <ilias.apalodimas@linaro•org>,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
"David S. Miller" <davem@davemloft•net>,
Jassi Brar <jaswinder.singh@linaro•org>,
Giuseppe Cavallaro <peppe.cavallaro@st•com>,
Alexandre Torgue <alexandre.torgue@st•com>,
Jose Abreu <joabreu@synopsys•com>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Jesper Dangaard Brouer <hawk@kernel•org>,
Jakub Kicinski <kuba@kernel•org>,
Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
John Fastabend <john.fastabend@gmail•com>,
linux-kernel@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, bpf@vger•kernel.org
Subject: Re: [PATCH net-next] net: page_pool: API cleanup and comments
Date: Sun, 16 Feb 2020 11:33:55 +0100 [thread overview]
Message-ID: <87k14mbz3g.fsf@toke.dk> (raw)
In-Reply-To: <20200216094056.8078-1-ilias.apalodimas@linaro.org>
Ilias Apalodimas <ilias.apalodimas@linaro•org> writes:
> Functions starting with __ usually indicate those which are exported,
> but should not be called directly. Update some of those declared in the
> API and make it more readable.
>
> page_pool_unmap_page() and page_pool_release_page() were doing
> exactly the same thing. Keep the page_pool_release_page() variant
> and export it in order to show up on perf logs.
> Finally rename __page_pool_put_page() to page_pool_put_page() since we
> can now directly call it from drivers and rename the existing
> page_pool_put_page() to page_pool_put_full_page() since they do the same
> thing but the latter is trying to sync the full DMA area.
>
> Also update netsec, mvneta and stmmac drivers which use those functions.
>
> Suggested-by: Jonathan Lemon <jonathan.lemon@gmail•com>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro•org>
Thanks for the house cleaning :)
Acked-by: Toke Høiland-Jørgensen <toke@redhat•com>
next prev parent reply other threads:[~2020-02-16 10:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 9:40 [PATCH net-next] net: page_pool: API cleanup and comments Ilias Apalodimas
2020-02-16 10:33 ` Toke Høiland-Jørgensen [this message]
2020-02-17 3:53 ` David Miller
2020-02-17 3:59 ` David Miller
2020-02-17 5:57 ` Ilias Apalodimas
2020-02-18 10:47 ` kbuild test robot
2020-02-18 11:22 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k14mbz3g.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=alexandre.torgue@st$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=hawk@kernel$(echo .)org \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=jaswinder.singh@linaro$(echo .)org \
--cc=joabreu@synopsys$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=lorenzo@kernel$(echo .)org \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox