From: Arseny Solokha <asolokha@kb•kras.ru>
To: Vladimir Oltean <olteanv@gmail•com>
Cc: Claudiu Manoil <claudiu.manoil@nxp•com>,
Russell King <linux@armlinux•org.uk>,
Ioana Ciornei <ioana.ciornei@nxp•com>,
Andrew Lunn <andrew@lunn•ch>, netdev <netdev@vger•kernel.org>,
Florian Fainelli <f.fainelli@gmail•com>
Subject: Re: [RFC PATCH 1/2] gianfar: convert to phylink
Date: Wed, 04 Sep 2019 20:53:38 +0700 [thread overview]
Message-ID: <87k1aop3q5.fsf@kb.kras.ru> (raw)
In-Reply-To: CA+h21hpacLmKzoeKrdE-frZSTsiYCi4rKCObJ4LfAmfrCJ6H9g@mail.gmail.com
Hi,
>> @@ -1964,7 +1966,7 @@ void stop_gfar(struct net_device *dev)
>> /* disable ints and gracefully shut down Rx/Tx DMA */
>> gfar_halt(priv);
>>
>> - phy_stop(dev->phydev);
>> + phylink_stop(priv->phylink);
>>
>> free_skb_resources(priv);
>> }
>> @@ -2219,12 +2221,7 @@ int startup_gfar(struct net_device *ndev)
>> /* Start Rx/Tx DMA and enable the interrupts */
>> gfar_start(priv);
>>
>> - /* force link state update after mac reset */
>> - priv->oldlink = 0;
>> - priv->oldspeed = 0;
>> - priv->oldduplex = -1;
>> -
>> - phy_start(ndev->phydev);
>> + phylink_start(priv->phylink);
>>
>> enable_napi(priv);
>>
>> @@ -2593,7 +2590,7 @@ static int gfar_close(struct net_device *dev)
>> stop_gfar(dev);
>>
>> /* Disconnect from the PHY */
>> - phy_disconnect(dev->phydev);
>> + phylink_disconnect_phy(priv->phylink);
>
> It is very odd to disconnect from the PHY on ndo_close and connect
> back on ndo_open. I don't know of any other driver that does that.
> Can't you change the behavior to simply start and stop phylink here?
I surely can. But I've just looked at xilinx_axienet, mvneta, mvpp2, and stmmac,
and they all call phylink_stop() and phylink_disconnect_phy() in ndo_stop. What
do you think would justify such a change?
next prev parent reply other threads:[~2019-09-04 13:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 15:17 [RFC PATCH 0/2] convert gianfar to phylink Arseny Solokha
2019-07-23 15:17 ` [RFC PATCH 1/2] gianfar: convert " Arseny Solokha
2019-07-23 16:07 ` Claudiu Manoil
2019-07-24 7:36 ` Arseny Solokha
2019-07-24 8:19 ` Russell King - ARM Linux admin
2019-07-29 23:39 ` Vladimir Oltean
2019-07-30 10:23 ` Russell King - ARM Linux admin
2019-08-24 12:49 ` Vladimir Oltean
2019-07-30 14:40 ` Arseny Solokha
2019-08-24 15:21 ` Vladimir Oltean
2019-08-28 15:20 ` Vladimir Oltean
2019-09-04 13:52 ` [PATCH 0/4] gianfar: some assorted cleanup Arseny Solokha
2019-09-04 13:52 ` [PATCH 1/4] gianfar: remove forward declarations Arseny Solokha
2019-09-04 13:52 ` [PATCH 2/4] gianfar: make five functions static Arseny Solokha
2019-09-04 13:52 ` [PATCH 3/4] gianfar: cleanup gianfar.h Arseny Solokha
2019-09-04 13:52 ` [PATCH 4/4] gianfar: use DT more consistently when selecting PHY connection type Arseny Solokha
2019-09-05 10:28 ` [PATCH 0/4] gianfar: some assorted cleanup David Miller
2019-09-05 10:39 ` Vladimir Oltean
2019-09-04 13:54 ` [RFC PATCH 1/2] gianfar: convert to phylink Arseny Solokha
2019-09-04 13:53 ` Arseny Solokha [this message]
2019-07-23 15:17 ` [RFC PATCH 2/2] net: phylink: don't start and stop SGMII PHYs in SFP modules twice Arseny Solokha
2019-07-24 9:01 ` Russell King - ARM Linux admin
2019-07-24 13:31 ` [PATCH v2] " Arseny Solokha
2019-07-24 13:36 ` Andrew Lunn
2019-07-24 13:37 ` Russell King - ARM Linux admin
2019-07-24 21:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1aop3q5.fsf@kb.kras.ru \
--to=asolokha@kb$(echo .)kras.ru \
--cc=andrew@lunn$(echo .)ch \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox