From: Gregory CLEMENT <gregory.clement@free-electrons•com>
To: David Miller <davem@davemloft•net>
Cc: linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
jszhang@marvell•com, arnd@arndb•de, jason@lakedaemon•net,
andrew@lunn•ch, sebastian.hesselbarth@gmail•com,
thomas.petazzoni@free-electrons•com,
linux-arm-kernel@lists•infradead.org, nadavh@marvell•com,
mw@semihalf•com, dima@marvell•com, yelena@marvell•com
Subject: Re: [PATCH v4 net-next 3/7] net: mvneta: Use cacheable memory to store the rx buffer virtual address
Date: Wed, 30 Nov 2016 22:27:47 +0100 [thread overview]
Message-ID: <87k2bklkto.fsf@free-electrons.com> (raw)
In-Reply-To: <20161130.135725.407314756675613303.davem@davemloft.net> (David Miller's message of "Wed, 30 Nov 2016 13:57:25 -0500 (EST)")
Hi David,
On mer., nov. 30 2016, David Miller <davem@davemloft•net> wrote:
> From: Gregory CLEMENT <gregory.clement@free-electrons•com>
> Date: Tue, 29 Nov 2016 15:55:21 +0100
>
>> + /* Virtual address of the RX buffer */
>> + void **buf_virt_addr;
>> +
>> /* Virtual address of the RX DMA descriptors array */
>> struct mvneta_rx_desc *descs;
>>
> ...
>> + data = (unsigned char *)rxq->buf_virt_addr[index];
>
> This cast is unnecessary, please remove it.
OK I am doing it now.
Thanks,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2016-11-30 21:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 14:55 [PATCH v4 net-next 0/7] Support Armada 37xx SoC (ARMv8 64-bits) in mvneta driver Gregory CLEMENT
2016-11-29 14:55 ` [PATCH v4 net-next 1/7] net: mvneta: Optimize rx path for small frame Gregory CLEMENT
2016-11-29 14:55 ` [PATCH v4 net-next 2/7] net: mvneta: Do not allocate buffer in rxq init with HWBM Gregory CLEMENT
2016-11-29 14:55 ` [PATCH v4 net-next 3/7] net: mvneta: Use cacheable memory to store the rx buffer virtual address Gregory CLEMENT
2016-11-30 18:57 ` David Miller
2016-11-30 21:27 ` Gregory CLEMENT [this message]
2016-11-29 14:55 ` [PATCH v4 net-next 4/7] net: mvneta: Convert to be 64 bits compatible Gregory CLEMENT
2016-11-29 14:55 ` [PATCH v4 net-next 5/7] net: mvneta: Only disable mvneta_bm for 64-bits Gregory CLEMENT
2016-11-29 14:55 ` [PATCH v4 net-next 6/7] net: mvneta: Add network support for Armada 3700 SoC Gregory CLEMENT
2016-11-29 14:55 ` [PATCH v4 net-next 7/7] ARM64: dts: marvell: Add network support for Armada 3700 Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2bklkto.fsf@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=dima@marvell$(echo .)com \
--cc=jason@lakedaemon$(echo .)net \
--cc=jszhang@marvell$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mw@semihalf$(echo .)com \
--cc=nadavh@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
--cc=yelena@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox