From: Kurt Kanzenbach <kurt@linutronix•de>
To: Vladimir Oltean <vladimir.oltean@nxp•com>, netdev@vger•kernel.org
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Jamal Hadi Salim <jhs@mojatatu•com>,
Cong Wang <xiyou.wangcong@gmail•com>,
Jiri Pirko <jiri@resnulli•us>,
Vinicius Costa Gomes <vinicius.gomes@intel•com>,
Gerhard Engleder <gerhard@engleder-embedded•com>,
Amritha Nambiar <amritha.nambiar@intel•com>,
Ferenc Fejes <ferenc.fejes@ericsson•com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp•com>,
Roger Quadros <rogerq@kernel•org>,
Pranavi Somisetty <pranavi.somisetty@amd•com>,
Harini Katakam <harini.katakam@amd•com>,
Giuseppe Cavallaro <peppe.cavallaro@st•com>,
Alexandre Torgue <alexandre.torgue@foss•st.com>,
Michael Sit Wei Hong <michael.wei.hong.sit@intel•com>,
Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel•com>,
Oleksij Rempel <linux@rempel-privat•de>,
Jacob Keller <jacob.e.keller@intel•com>,
linux-kernel@vger•kernel.org, Andrew Lunn <andrew@lunn•ch>,
Florian Fainelli <f.fainelli@gmail•com>,
Claudiu Manoil <claudiu.manoil@nxp•com>,
Alexandre Belloni <alexandre.belloni@bootlin•com>,
UNGLinuxDriver@microchip•com,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
Horatiu Vultur <horatiu.vultur@microchip•com>,
Jose Abreu <joabreu@synopsys•com>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
intel-wired-lan@lists•osuosl.org,
Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel•com>
Subject: Re: [PATCH net-next 2/5] net/sched: taprio: replace tc_taprio_qopt_offload :: enable with a "cmd" enum
Date: Tue, 30 May 2023 14:20:50 +0200 [thread overview]
Message-ID: <87leh6qacd.fsf@kurt> (raw)
In-Reply-To: <20230530091948.1408477-3-vladimir.oltean@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 2060 bytes --]
On Tue May 30 2023, Vladimir Oltean wrote:
> Inspired from struct flow_cls_offload :: cmd, in order for taprio to be
> able to report statistics (which is future work), it seems that we need
> to drill one step further with the ndo_setup_tc(TC_SETUP_QDISC_TAPRIO)
> multiplexing, and pass the command as part of the common portion of the
> muxed structure.
>
> Since we already have an "enable" variable in tc_taprio_qopt_offload,
> refactor all drivers to check for "cmd" instead of "enable", and reject
> every other command except "replace" and "destroy" - to be future proof.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp•com>
> ---
[...]
> diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c
> index 595a548bb0a8..af50001ccdd4 100644
> --- a/drivers/net/dsa/hirschmann/hellcreek.c
> +++ b/drivers/net/dsa/hirschmann/hellcreek.c
> @@ -1885,13 +1885,17 @@ static int hellcreek_port_setup_tc(struct dsa_switch *ds, int port,
> case TC_SETUP_QDISC_TAPRIO: {
> struct tc_taprio_qopt_offload *taprio = type_data;
>
> - if (!hellcreek_validate_schedule(hellcreek, taprio))
> - return -EOPNOTSUPP;
> + switch (taprio->cmd) {
> + case TAPRIO_CMD_REPLACE:
> + if (!hellcreek_validate_schedule(hellcreek, taprio))
> + return -EOPNOTSUPP;
>
> - if (taprio->enable)
> return hellcreek_port_set_schedule(ds, port, taprio);
> -
> - return hellcreek_port_del_schedule(ds, port);
> + case TAPRIO_CMD_DESTROY:
> + return hellcreek_port_del_schedule(ds, port);
> + default:
> + return -EOPNOTSUPP;
> + }
> }
> default:
> return -EOPNOTSUPP;
Uhm, seems like the current code validates the schedule even for
removing a schedule which seems a bit odd. With your changes it looks
correct.
Acked-by: Kurt Kanzenbach <kurt@linutronix•de> # hellcreek
Anyway, the hellcreek device has Tx overrun counters per TC. Even though
they should be zero, simply because the hardware Length Aware Shaper is
enabled by default.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2023-05-30 12:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 9:19 [PATCH net-next 0/5] xstats for tc-taprio Vladimir Oltean
2023-05-30 9:19 ` [PATCH net-next 1/5] net/sched: taprio: don't overwrite "sch" variable in taprio_dump_class_stats() Vladimir Oltean
2023-05-30 21:14 ` Vinicius Costa Gomes
2023-05-30 21:32 ` Vladimir Oltean
2023-05-30 22:33 ` Vinicius Costa Gomes
2023-05-30 9:19 ` [PATCH net-next 2/5] net/sched: taprio: replace tc_taprio_qopt_offload :: enable with a "cmd" enum Vladimir Oltean
2023-05-30 12:01 ` Horatiu Vultur
2023-05-30 12:20 ` Kurt Kanzenbach [this message]
2023-05-30 12:45 ` Zulkifli, Muhammad Husaini
2023-05-30 20:50 ` Gerhard Engleder
2023-05-31 17:08 ` Simon Horman
2023-05-31 17:10 ` Vladimir Oltean
2023-05-30 9:19 ` [PATCH net-next 3/5] net/sched: taprio: add netlink reporting for offload statistics counters Vladimir Oltean
2023-05-30 22:52 ` Vinicius Costa Gomes
2023-05-31 13:33 ` Vladimir Oltean
2023-05-31 10:54 ` Zulkifli, Muhammad Husaini
2023-05-30 9:19 ` [PATCH net-next 4/5] net: enetc: refactor enetc_setup_tc_taprio() to have a switch/case for cmd Vladimir Oltean
2023-05-30 9:19 ` [PATCH net-next 5/5] net: enetc: report statistics counters for taprio Vladimir Oltean
2023-05-31 9:10 ` [PATCH net-next 0/5] xstats for tc-taprio patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leh6qacd.fsf@kurt \
--to=kurt@linutronix$(echo .)de \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=amritha.nambiar@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=ferenc.fejes@ericsson$(echo .)com \
--cc=gerhard@engleder-embedded$(echo .)com \
--cc=harini.katakam@amd$(echo .)com \
--cc=horatiu.vultur@microchip$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=joabreu@synopsys$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@rempel-privat$(echo .)de \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=michael.wei.hong.sit@intel$(echo .)com \
--cc=mohammad.athari.ismail@intel$(echo .)com \
--cc=muhammad.husaini.zulkifli@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=pranavi.somisetty@amd$(echo .)com \
--cc=rogerq@kernel$(echo .)org \
--cc=vinicius.gomes@intel$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=xiaoliang.yang_1@nxp$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox