From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Felix Fietkau <nbd@nbd•name>, netdev@vger•kernel.org
Subject: Re: [PATCH 2/2] sch_fq_codel: fix running with classifiers that don't set a classid
Date: Mon, 07 Mar 2022 21:41:01 +0100 [thread overview]
Message-ID: <87lexl7axu.fsf@toke.dk> (raw)
In-Reply-To: <20220307182602.16978-2-nbd@nbd.name>
Felix Fietkau <nbd@nbd•name> writes:
> If no valid classid is provided, fall back to calculating the hash directly,
> in order to avoid dropping packets
>
> Signed-off-by: Felix Fietkau <nbd@nbd•name>
While I agree that this behaviour makes more sense, it's also a
user-facing API change; I suppose there may be filters out there relying
on the fact that invalid (or unset) class ID values lead to dropped
packets?
-Toke
next prev parent reply other threads:[~2022-03-07 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 18:26 [PATCH 1/2] sch_cake: allow setting TCA_CAKE_NAT with value 0 if conntrack is disabled Felix Fietkau
2022-03-07 18:26 ` [PATCH 2/2] sch_fq_codel: fix running with classifiers that don't set a classid Felix Fietkau
2022-03-07 20:41 ` Toke Høiland-Jørgensen [this message]
2022-03-07 22:43 ` Eric Dumazet
2022-03-07 20:37 ` [PATCH 1/2] sch_cake: allow setting TCA_CAKE_NAT with value 0 if conntrack is disabled Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lexl7axu.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox