From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Lorenzo Bianconi <lorenzo@kernel•org>
Cc: bpf@vger•kernel.org, netdev@vger•kernel.org,
lorenzo.bianconi@redhat•com, davem@davemloft•net,
kuba@kernel•org, ast@kernel•org, daniel@iogearbox•net,
shayagr@amazon•com, john.fastabend@gmail•com, dsahern@kernel•org,
brouer@redhat•com, echaudro@redhat•com, jasowang@redhat•com,
alexander.duyck@gmail•com, saeed@kernel•org,
maciej.fijalkowski@intel•com, magnus.karlsson@intel•com,
tirthendu.sarkar@intel•com
Subject: Re: [PATCH v16 bpf-next 09/20] bpf: introduce BPF_F_XDP_MB flag in prog_flags loading the ebpf program
Date: Fri, 15 Oct 2021 18:03:47 +0200 [thread overview]
Message-ID: <87lf2uz34s.fsf@toke.dk> (raw)
In-Reply-To: <YWmCLlLelmG2ElyV@lore-desk>
Lorenzo Bianconi <lorenzo@kernel•org> writes:
>> Lorenzo Bianconi <lorenzo@kernel•org> writes:
>>
>> > Introduce BPF_F_XDP_MB and the related field in bpf_prog_aux in order to
>> > notify the driver the loaded program support xdp multi-buffer.
>>
>> We should also add some restrictions in the BPF core. In particular,
>> tail call, cpumap and devmap maps should not be able to mix multi-buf
>> and non-multibuf programs.
>
> ack. How can we detect if a cpumap or a devmap is running in XDP multi-buff
> mode in order to reject loading the legacy XDP program?
I was hoping we could copy the same mechanism that tail call maps to
ensure that callers and callees are the same type. And amend that to
also consider the xdp_mb flag while we're at it :)
> Should we just discard the XDP multi-buff in this case?
If I'm right in the above, we won't have to because the verifier can
ensure that the program types match...
-Toke
next prev parent reply other threads:[~2021-10-15 16:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 13:08 [PATCH v16 bpf-next 00/20] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 01/20] net: skbuff: add size metadata to skb_shared_info for xdp Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 02/20] xdp: introduce flags field in xdp_buff/xdp_frame Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 03/20] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 04/20] net: mvneta: simplify mvneta_swbm_add_rx_fragment management Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 05/20] net: xdp: add xdp_update_skb_shared_info utility routine Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 06/20] net: marvell: rely on " Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 07/20] xdp: add multi-buff support to xdp_return_{buff/frame} Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 08/20] net: mvneta: add multi buffer support to XDP_TX Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 09/20] bpf: introduce BPF_F_XDP_MB flag in prog_flags loading the ebpf program Lorenzo Bianconi
2021-10-15 13:22 ` Toke Høiland-Jørgensen
2021-10-15 13:29 ` Lorenzo Bianconi
2021-10-15 16:03 ` Toke Høiland-Jørgensen [this message]
2021-10-15 13:08 ` [PATCH v16 bpf-next 10/20] net: mvneta: enable jumbo frames if the loaded XDP program support mb Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 11/20] bpf: add multi-buff support to the bpf_xdp_adjust_tail() API Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 12/20] bpf: introduce bpf_xdp_get_buff_len helper Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 13/20] bpf: add multi-buffer support to xdp copy helpers Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 14/20] bpf: move user_size out of bpf_test_init Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 15/20] bpf: introduce multibuff support to bpf_prog_test_run_xdp() Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 16/20] bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 17/20] bpf: update xdp_adjust_tail selftest to include multi-buffer Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 18/20] libbpf: Add SEC name for xdp_mb programs Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 19/20] net: xdp: introduce bpf_xdp_pointer utility routine Lorenzo Bianconi
2021-10-27 22:53 ` Daniel Borkmann
2021-10-28 9:26 ` Lorenzo Bianconi
2021-10-15 13:08 ` [PATCH v16 bpf-next 20/20] bpf: introduce bpf_xdp_{load,store}_bytes selftest Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf2uz34s.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=brouer@redhat$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=echaudro@redhat$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lorenzo.bianconi@redhat$(echo .)com \
--cc=lorenzo@kernel$(echo .)org \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saeed@kernel$(echo .)org \
--cc=shayagr@amazon$(echo .)com \
--cc=tirthendu.sarkar@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox