From: Vincent Bernat <vincent@bernat•im>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH iproute2-next] color: disable color when json output is requested
Date: Wed, 21 Feb 2018 06:58:47 +0100 [thread overview]
Message-ID: <87lgfmsx2g.fsf@luffy.cx> (raw)
In-Reply-To: <20180220160455.1e89c0be@xeon-e3> (Stephen Hemminger's message of "Tue, 20 Feb 2018 16:04:55 -0800")
❦ 20 février 2018 16:04 -0800, Stephen Hemminger <stephen@networkplumber•org> :
>> Instead of declaring -color and -json exclusive, ignore -color when
>> -json is provided. The rationale is to allow to put -color in an alias
>> for ip while still being able to use -json. -color is merely a
>> presentation suggestion and we can assume there is nothing to color in
>> the JSON output.
>>
>> Signed-off-by: Vincent Bernat <vincent@bernat•im>
>
> Looks fine to me, this could even go into master.
> Need to update man page and make sure behavior is consistent
> across ip, tc, and bridge commands.
Currently, in master or net-next, only the "ip" command has a -color
option.
--
The human race is a race of cowards; and I am not only marching in that
procession but carrying a banner.
-- Mark Twain
prev parent reply other threads:[~2018-02-21 6:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 23:28 [PATCH iproute2-next] color: disable color when json output is requested Vincent Bernat
2018-02-21 0:04 ` Stephen Hemminger
2018-02-21 5:58 ` Vincent Bernat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgfmsx2g.fsf@luffy.cx \
--to=vincent@bernat$(echo .)im \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox