Subject: Re: [RFC]RNDIS filter issue

From: Bjørn Mork <[email-masked]>
Date: Thu, 18 May 2017 15:02:30 +0200

Oliver Neukum <[email-masked]> writes:

> @@ -472,7 +489,6 @@ static void usbnet_cdc_zte_status(struct usbnet *dev, struct urb *urb)
>  
>  	if (urb->actual_length < sizeof(*event))
>  		return;
> -
>  	event = urb->transfer_buffer;
>  
>  	if (event->bNotificationType != USB_CDC_NOTIFY_NETWORK_CONNECTION) {

Spurious whitespace.

And building gives:

 /usr/local/src/git/linux/drivers/net/usb/cdc_ether.c:325:5: warning: symbol 'usbnet_ether_cdc_bind' was not declared. Should it be static?

and maybe it should?  There is no use for it in any other module, yet.
Or you could declare it in usbnet.h, I guess.  Your choice.

Looks good to me if those two minor issues are fixed.  But do note that
I currently don't have any way to test this on real hardware...

Bjørn