From: ebiederm@xmission•com (Eric W. Biederman)
To: Steffen Klassert <steffen.klassert@secunet•com>
Cc: Tom Herbert <therbert@google•com>,
netdev@vger•kernel.org, davem@davemloft•net,
eric.dumazet@gmail•com
Subject: Re: [PATCH] soreuseport: fix use of uid in tb->fastuid
Date: Tue, 29 Jan 2013 04:26:08 -0800 [thread overview]
Message-ID: <87libc9nvj.fsf@xmission.com> (raw)
In-Reply-To: <20130128074707.GN9147@secunet.com> (Steffen Klassert's message of "Mon, 28 Jan 2013 08:47:07 +0100")
Steffen Klassert <steffen.klassert@secunet•com> writes:
> On Sat, Jan 26, 2013 at 09:50:54AM -0800, Tom Herbert wrote:
>> Fix a reported compilation error where ia variable of type kuid_t
>> was being set to zero.
>>
>
> Thanks for fixing this.
> Unfortunately I get another compilation error now:
>
> net/ipv6/inet6_connection_sock.c: In function ‘inet6_csk_bind_conflict’:
> net/ipv6/inet6_connection_sock.c:37:12: error: incompatible types when initializing type ‘int’ using type ‘kuid_t’
> net/ipv6/inet6_connection_sock.c:54:30: error: incompatible type for argument 1 of ‘uid_eq’
> include/linux/uidgid.h:70:20: note: expected ‘kuid_t’ but argument is of type ‘int’
> make[3]: *** [net/ipv6/inet6_connection_sock.o] Error 1
>
> I wondered why noone else is seeing this, so I did some analysis.
> I'm getting this because of the UIDGID_STRICT_TYPE_CHECKS config option.
> This is selected by USER_NS which in turn depends on UIDGID_CONVERTED.
> Most people can't enable USER_NS because they compile something like
> nfs or anything else that is not 'UIDGID_CONVERTED'.
Yes. There are currently 11 filesystems whose uid_t to kuid_t
conversions have not yet been merged. I am working on those
conversions now and with a little luck I will have everything
ready them all converted by 3.9.
Eric
prev parent reply other threads:[~2013-01-29 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 17:50 [PATCH] soreuseport: fix use of uid in tb->fastuid Tom Herbert
2013-01-27 6:02 ` David Miller
2013-01-28 7:47 ` Steffen Klassert
2013-01-29 12:26 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87libc9nvj.fsf@xmission.com \
--to=ebiederm@xmission$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=therbert@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox