From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Peter Seiderer <ps.report@gmx•net>, netdev@vger•kernel.org
Cc: linux-kernel@vger•kernel.org,
"David S . Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Simon Horman <horms@kernel•org>,
Peter Seiderer <ps.report@gmx•net>
Subject: Re: [PATCH net-next v1 00/11] net: pktgen: fix checkpatch code style errors/warnings
Date: Thu, 10 Apr 2025 13:24:41 +0200 [thread overview]
Message-ID: <87mscotg1y.fsf@toke.dk> (raw)
In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net>
Peter Seiderer <ps.report@gmx•net> writes:
> Fix checkpatch detected code style errors/warnings detected in
> the file net/core/pktgen.c (remaining checkpatch checks will be addressed
> in a follow up patch set).
>
> Peter Seiderer (11):
> net: pktgen: fix code style (ERROR: "foo * bar" should be "foo *bar")
> net: pktgen: fix code style (ERROR: space prohibited after that '&')
> net: pktgen: fix code style (ERROR: else should follow close brace
> '}')
> net: pktgen: fix code style (WARNING: please, no space before tabs)
> net: pktgen: fix code style (WARNING: suspect code indent for
> conditional statements)
> net: pktgen: fix code style (WARNING: Block comments)
> net: pktgen: fix code style (WARNING: Missing a blank line after
> declarations)
> net: pktgen: fix code style (WARNING: macros should not use a trailing
> semicolon)
> net: pktgen: fix code style (WARNING: braces {} are not necessary for
> single statement blocks)
> net: pktgen: fix code style (WARNING: quoted string split across
> lines)
> net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy)
>
> net/core/pktgen.c | 111 ++++++++++++++++++++++++++--------------------
> 1 file changed, 64 insertions(+), 47 deletions(-)
Most of these are pretty marginal improvements, so I'm a little on the
fence about whether they are worth it. But, well, they do improve things
slightly, so if the maintainers are OK with the churn:
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat•com>
next prev parent reply other threads:[~2025-04-10 11:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 7:17 [PATCH net-next v1 00/11] net: pktgen: fix checkpatch code style errors/warnings Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 01/11] net: pktgen: fix code style (ERROR: "foo * bar" should be "foo *bar") Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 02/11] net: pktgen: fix code style (ERROR: space prohibited after that '&') Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 03/11] net: pktgen: fix code style (ERROR: else should follow close brace '}') Peter Seiderer
2025-04-14 21:48 ` Jakub Kicinski
2025-04-10 7:17 ` [PATCH net-next v1 04/11] net: pktgen: fix code style (WARNING: please, no space before tabs) Peter Seiderer
2025-04-14 21:49 ` Jakub Kicinski
2025-04-10 7:17 ` [PATCH net-next v1 05/11] net: pktgen: fix code style (WARNING: suspect code indent for conditional statements) Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 06/11] net: pktgen: fix code style (WARNING: Block comments) Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 07/11] net: pktgen: fix code style (WARNING: Missing a blank line after declarations) Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 08/11] net: pktgen: fix code style (WARNING: macros should not use a trailing semicolon) Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 09/11] net: pktgen: fix code style (WARNING: braces {} are not necessary for single statement blocks) Peter Seiderer
2025-04-14 21:51 ` Jakub Kicinski
2025-04-10 7:17 ` [PATCH net-next v1 10/11] net: pktgen: fix code style (WARNING: quoted string split across lines) Peter Seiderer
2025-04-10 7:17 ` [PATCH net-next v1 11/11] net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy) Peter Seiderer
2025-04-14 21:52 ` Jakub Kicinski
2025-04-10 11:24 ` Toke Høiland-Jørgensen [this message]
2025-04-14 22:57 ` [PATCH net-next v1 00/11] net: pktgen: fix checkpatch code style errors/warnings patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mscotg1y.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=ps.report@gmx$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox