From: Kalle Valo <kvalo-A+ZNKFmMK5xy9aJCnZT0Uw@public•gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public•gmane.org>
Cc: Ryan Hsu <ryanhsu-Rm6X0d1/PG5y9aJCnZT0Uw@public•gmane.org>,
Govind Singh <govinds-Rm6X0d1/PG5y9aJCnZT0Uw@public•gmane.org>,
Srinivas Kandagatla
<srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public•gmane.org>,
Ashok Raj Nagarajan
<arnagara-Rm6X0d1/PG5y9aJCnZT0Uw@public•gmane.org>,
Ben Greear <greearb-my8/4N5VtI7c+919tysfdA@public•gmane.org>,
"Brian Norris"
<briannorris-F7+t8E8rja9g9hUCZPvPmw@public•gmane.org>,
Colin Ian King
<colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public•gmane.org>,
"ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org"
<ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org>,
"linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: [PATCH] ath10k: move pci suspend/resume functions
Date: Thu, 2 Nov 2017 15:23:42 +0000 [thread overview]
Message-ID: <87mv44ln5v.fsf@qca.qualcomm.com> (raw)
In-Reply-To: <20171102110903.2886660-1-arnd-r2nGTMty4D4@public.gmane.org> (Arnd Bergmann's message of "Thu, 2 Nov 2017 12:08:53 +0100")
Arnd Bergmann <arnd-r2nGTMty4D4@public•gmane.org> writes:
> The combination of two patches has led to a build failure:
>
> drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_suspend':
> drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit declaration of function 'ath10k_pci_suspend'; did you mean 'ath10k_pci_pm_suspend'? [-Werror=implicit-function-declaration]
> drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_resume':
> drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit declaration of function 'ath10k_pci_resume'; did you mean 'ath10k_pci_pm_resume'? [-Werror=implicit-function-declaration]
>
> This moves the functions outside of the now incorrect #ifdef.
>
> Fixes: 96378bd2c6cd ("ath10k: fix core PCI suspend when WoWLAN is supported but disabled")
> Fixes: 6af1de2e4ec4 ("ath10k: mark PM functions as __maybe_unused")
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public•gmane.org>
Brian has already fixed this, please check that:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=20665a9076d48e9abd9a2db13d307f58f7ef6647
But apparently I forgot to merge ath-next to wireless-drivers-next, will
do that soon.
--
Kalle Valo
next prev parent reply other threads:[~2017-11-02 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 11:08 [PATCH] ath10k: move pci suspend/resume functions Arnd Bergmann
[not found] ` <20171102110903.2886660-1-arnd-r2nGTMty4D4@public.gmane.org>
2017-11-02 15:23 ` Kalle Valo [this message]
2017-11-02 15:40 ` Arnd Bergmann
2017-11-02 17:10 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv44ln5v.fsf@qca.qualcomm.com \
--to=kvalo-a+znkfmmk5xy9ajcnzt0uw@public$(echo .)gmane.org \
--cc=arnagara-Rm6X0d1/PG5y9aJCnZT0Uw@public$(echo .)gmane.org \
--cc=arnd-r2nGTMty4D4@public$(echo .)gmane.org \
--cc=ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public$(echo .)gmane.org \
--cc=briannorris-F7+t8E8rja9g9hUCZPvPmw@public$(echo .)gmane.org \
--cc=colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public$(echo .)gmane.org \
--cc=govinds-Rm6X0d1/PG5y9aJCnZT0Uw@public$(echo .)gmane.org \
--cc=greearb-my8/4N5VtI7c+919tysfdA@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=ryanhsu-Rm6X0d1/PG5y9aJCnZT0Uw@public$(echo .)gmane.org \
--cc=srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox