From: Petr Machata <petrm@nvidia•com>
To: Daniel Machon <daniel.machon@microchip•com>
Cc: <netdev@vger•kernel.org>, <davem@davemloft•net>,
<petrm@nvidia•com>, <maxime.chevallier@bootlin•com>,
<thomas.petazzoni@bootlin•com>, <edumazet@google•com>,
<kuba@kernel•org>, <pabeni@redhat•com>,
<lars.povlsen@microchip•com>, <Steen.Hegelund@microchip•com>,
<UNGLinuxDriver@microchip•com>, <joe@perches•com>,
<linux@armlinux•org.uk>, <horatiu.vultur@microchip•com>,
<Julia.Lawall@inria•fr>, <vladimir.oltean@nxp•com>,
<linux-kernel@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH net-next v4 1/6] net: dcb: add new pcp selector to app object
Date: Mon, 31 Oct 2022 12:13:43 +0100 [thread overview]
Message-ID: <87o7tsw7ji.fsf@nvidia.com> (raw)
In-Reply-To: <20221028100320.786984-2-daniel.machon@microchip.com>
Daniel Machon <daniel.machon@microchip•com> writes:
> diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
> index dc4fb699b56c..68e033a459af 100644
> --- a/net/dcb/dcbnl.c
> +++ b/net/dcb/dcbnl.c
> @@ -179,6 +179,57 @@ static const struct nla_policy dcbnl_featcfg_nest[DCB_FEATCFG_ATTR_MAX + 1] = {
> static LIST_HEAD(dcb_app_list);
> static DEFINE_SPINLOCK(dcb_lock);
>
> +static enum ieee_attrs_app dcbnl_app_attr_type_get(u8 selector)
> +{
> + switch (selector) {
> + case IEEE_8021QAZ_APP_SEL_ETHERTYPE:
> + case IEEE_8021QAZ_APP_SEL_STREAM:
> + case IEEE_8021QAZ_APP_SEL_DGRAM:
> + case IEEE_8021QAZ_APP_SEL_ANY:
> + case IEEE_8021QAZ_APP_SEL_DSCP:
> + return DCB_ATTR_IEEE_APP;
> + case DCB_APP_SEL_PCP:
> + return DCB_ATTR_DCB_APP;
> + default:
> + return DCB_ATTR_IEEE_APP_UNSPEC;
> + }
> +}
> +
> +static bool dcbnl_app_attr_type_validate(enum ieee_attrs_app type)
> +{
> + switch (type) {
> + case DCB_ATTR_IEEE_APP:
> + case DCB_ATTR_DCB_APP:
> + return true;
> + default:
> + return false;
> + }
> +}
> +
> +static bool dcbnl_app_selector_validate(enum ieee_attrs_app type, u32 selector)
> +{
> + switch (selector) {
> + case IEEE_8021QAZ_APP_SEL_ETHERTYPE:
> + case IEEE_8021QAZ_APP_SEL_STREAM:
> + case IEEE_8021QAZ_APP_SEL_DGRAM:
> + case IEEE_8021QAZ_APP_SEL_ANY:
> + case IEEE_8021QAZ_APP_SEL_DSCP:
> + /* IEEE std selectors in IEEE std attribute */
> + if (type == DCB_ATTR_IEEE_APP)
> + return true;
> + else
> + return false;
AKA return type == DCB_ATTR_IEEE_APP;
> + case DCB_APP_SEL_PCP:
> + /* Non-std selectors in non-std attribute */
> + if (type == DCB_ATTR_DCB_APP)
> + return true;
> + else
> + return false;
Likewise here.
> + default:
> + return false;
> + }
Also, it really looks like the following would be equivalent?
static bool dcbnl_app_selector_validate(enum ieee_attrs_app type, u32 selector)
{
return dcbnl_app_attr_type_get(selector) == type;
}
Also, shouldn't it be u8 selector?
> +}
> +
> static struct sk_buff *dcbnl_newmsg(int type, u8 cmd, u32 port, u32 seq,
> u32 flags, struct nlmsghdr **nlhp)
> {
next prev parent reply other threads:[~2022-10-31 11:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 10:03 [PATCH net-next v4 0/6] Add new PCP and APPTRUST attributes to dcbnl Daniel Machon
2022-10-28 10:03 ` [PATCH net-next v4 1/6] net: dcb: add new pcp selector to app object Daniel Machon
2022-10-31 11:13 ` Petr Machata [this message]
2022-10-31 12:39 ` Daniel.Machon
2022-10-28 10:03 ` [PATCH net-next v4 2/6] net: dcb: add new apptrust attribute Daniel Machon
2022-10-31 12:24 ` Petr Machata
2022-10-31 12:45 ` Daniel.Machon
2022-10-31 16:24 ` Petr Machata
2022-10-28 10:03 ` [PATCH net-next v4 3/6] net: microchip: sparx5: add support for offloading pcp table Daniel Machon
2022-10-28 10:03 ` [PATCH net-next v4 4/6] net: microchip: sparx5: add support for apptrust Daniel Machon
2022-10-28 10:03 ` [PATCH net-next v4 5/6] net: microchip: sparx5: add support for offloading dscp table Daniel Machon
2022-10-28 10:03 ` [PATCH net-next v4 6/6] net: microchip: sparx5: add support for offloading default prio Daniel Machon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7tsw7ji.fsf@nvidia.com \
--to=petrm@nvidia$(echo .)com \
--cc=Julia.Lawall@inria$(echo .)fr \
--cc=Steen.Hegelund@microchip$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=daniel.machon@microchip$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horatiu.vultur@microchip$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lars.povlsen@microchip$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox