From: Kalle Valo <kvalo@kernel•org>
To: Souptick Joarder <jrdr.linux@gmail•com>
Cc: loic.poulain@linaro•org, davem@davemloft•net, kuba@kernel•org,
nathan@kernel•org, ndesaulniers@google•com,
ryan.odonoghue@linaro•org, wcn36xx@lists•infradead.org,
linux-wireless@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, llvm@lists•linux.dev,
kernel test robot <lkp@intel•com>
Subject: Re: [PATCH] wcn36xx: Initialize channel to NULL inside wcn36xx_change_opchannel()
Date: Mon, 21 Feb 2022 11:25:49 +0200 [thread overview]
Message-ID: <87o830y3j6.fsf@kernel.org> (raw)
In-Reply-To: <20220219152912.93580-1-jrdr.linux@gmail.com> (Souptick Joarder's message of "Sat, 19 Feb 2022 20:59:12 +0530")
Souptick Joarder <jrdr.linux@gmail•com> writes:
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail•com>
>
> Kernel test robot reported below warning ->
> drivers/net/wireless/ath/wcn36xx/main.c:409:7: warning: Branch
> condition evaluates to a garbage value
> [clang-analyzer-core.uninitialized.Branch]
>
> Also code walk indicates, if channel is not found in first band,
> it will break the loop and instead of exit it will go ahead and
> assign a garbage value in wcn->channel which looks like a bug.
>
> Initialize channel with NULL should avoid this issue.
>
> Fixes: d6f2746691cb ("wcn36xx: Track the band and channel we are tuned to")
> Reported-by: kernel test robot <lkp@intel•com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail•com>
> ---
> drivers/net/wireless/ath/wcn36xx/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index 75661d449712..1a06eff07107 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -394,7 +394,7 @@ static void wcn36xx_change_opchannel(struct wcn36xx *wcn, int ch)
> struct ieee80211_vif *vif = NULL;
> struct wcn36xx_vif *tmp;
> struct ieee80211_supported_band *band;
> - struct ieee80211_channel *channel;
> + struct ieee80211_channel *channel = NULL;
> unsigned long flags;
> int i, j;
I have already applied an identical patch from Dan:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=11e41e2929378df945bf50b95409d93059ad4507
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-02-21 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 15:29 [PATCH] wcn36xx: Initialize channel to NULL inside wcn36xx_change_opchannel() Souptick Joarder
2022-02-21 8:15 ` Loic Poulain
2022-02-21 9:25 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o830y3j6.fsf@kernel.org \
--to=kvalo@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jrdr.linux@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=lkp@intel$(echo .)com \
--cc=llvm@lists$(echo .)linux.dev \
--cc=loic.poulain@linaro$(echo .)org \
--cc=nathan@kernel$(echo .)org \
--cc=ndesaulniers@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ryan.odonoghue@linaro$(echo .)org \
--cc=wcn36xx@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox