Subject: Re: [PATCH] net: clear iflink when moving to a new netns

From: [email-masked] (Eric W. Biederman)
Date: Wed, 12 Feb 2014 18:01:48 -0800

Cong Wang <[email-masked]> writes:

> On Wed, Feb 12, 2014 at 8:33 AM, Stephen Hemminger
> <[email-masked]> wrote:
>>
>> This also breaks propogation of state changes from lower device
>> to upper device. Things like carrier and up/down.
>>
>
> macvlan_device_event() handles this pretty well by using a pointer to
> net_device.
> I don't see it is a problem from the code.

A quick grep shows two uses of iflink in net/core/link_watch.c that are
likely broken by your proposed change.

Eric