Subject: Re: [PATCH net-next v2 2/3] net_sched: fix some checkpatch errors

From: Bjørn Mork <[email-masked]>
Date: Fri, 08 Nov 2013 12:04:16 +0100

Daniel Borkmann <[email-masked]> writes:
> On 11/07/2013 03:13 AM, Yang Yingliang wrote:
>
>> @@ -263,7 +264,7 @@ void tcf_hash_insert(struct tcf_common *p, struct tcf_hashinfo *hinfo)
>>   }
>>   EXPORT_SYMBOL(tcf_hash_insert);
>>
>> -static struct tc_action_ops *act_base = NULL;
>> +static struct tc_action_ops *act_base;
>
> From a readability point of view, I think this makes it worse, also the other places
> where you change globals vars like that.

Then you should probably argue for a change to checkpatch. It will make
a lot of noise about such unnecessary initialization.

Bjørn