Subject: Re: [PATCH v2 net 4/5] net/sched: sch_cake: annotate data-races in cake_dump_stats() (IV)

From: Toke Høiland-Jørgensen <[email-masked]>
Date: Mon, 27 Apr 2026 10:45:25 +0200

Eric Dumazet <[email-masked]> writes:

> cake_dump_stats() runs without qdisc spinlock being held.
>
> In this fourth patch, I add READ_ONCE()/WRITE_ONCE() annotations
> for the following fields:
>
> - avg_peak_bandwidth
> - buffer_limit
> - buffer_max_used
> - avg_netoff
> - max_netlen
> - max_adjlen
> - min_netlen
> - min_adjlen
> - active_queues
> - tin_rate_bps
> - bytes
> - tin_backlog
>
> Other annotations are added in following patch, to ease code review.
>
> Fixes: 046f6fd5daef ("sched: Add Common Applications Kept Enhanced (cake) qdisc")
> Signed-off-by: Eric Dumazet <[email-masked]>
> Cc: "Toke Høiland-Jørgensen" <[email-masked]>

Looks better, thank you for re-spinning!

Acked-by: Toke Høiland-Jørgensen <[email-masked]>