Subject: Re: [PATCH v2 net-next 0/5] net_sched: sch_fq: round of improvements

From: Toke Høiland-Jørgensen <[email-masked]>
Date: Thu, 21 Sep 2023 11:33:48 +0200

Willem de Bruijn <[email-masked]> writes:

> On Wed, Sep 20, 2023 at 7:22 PM Jamal Hadi Salim <[email-masked]> wrote:
>>
>> On Wed, Sep 20, 2023 at 4:17 PM Eric Dumazet <[email-masked]> wrote:
>> >
>> > For FQ tenth anniversary, it was time for making it faster.
>> >
>> > The FQ part (as in Fair Queue) is rather expensive, because
>> > we have to classify packets and store them in a per-flow structure,
>> > and add this per-flow structure in a hash table. Then the RR lists
>> > also add cache line misses.
>> >
>> > Most fq qdisc are almost idle. Trying to share NIC bandwidth has
>> > no benefits, thus the qdisc could behave like a FIFO.
>> >
>> > This series brings a 5 % throughput increase in intensive
>> > tcp_rr workload, and 13 % increase for (unpaced) UDP packets.
>> >
>> > v2: removed an extra label (build bot).
>> >     Fix an accidental increase of stat_internal_packets counter
>> >     in fast path.
>> >     Added "constify qdisc_priv()" patch to allow fq_fastpath_check()
>> >     first parameter to be const.
>> >     typo on 'eligible' (Willem)
>>
>> For the patchset:
>> Reviewed-by: Jamal Hadi Salim <[email-masked]>
>
> Reviewed-by: Willem de Bruijn <[email-masked]>

Might as well join the party - nice set of improvements! :)

Reviewed-by: Toke Høiland-Jørgensen <[email-masked]>