Subject: Re: [PATCH v2 iproute2-next 1/2] tc: support the netem seed parameter for loss and corruption events

From: Petr Machata <[email-masked]>
Date: Wed, 30 Aug 2023 15:22:41 +0200

François Michel <[email-masked]> writes:

> Hi,
>
> Le 29/08/23 à 12:07, Petr Machata a écrit :
>> Took me a while to fight my way through all the unreads to this, and
>> it's already merged, but...
>> [email-masked] writes:
>> 
>>> diff --git a/tc/q_netem.c b/tc/q_netem.c
>>> index 8ace2b61..febddd49 100644
>>> --- a/tc/q_netem.c
>>> +++ b/tc/q_netem.c
>>> @@ -31,6 +31,7 @@ static void explain(void)
>>>   		"                 [ loss random PERCENT [CORRELATION]]\n"
>>>   		"                 [ loss state P13 [P31 [P32 [P23 P14]]]\n"
>>>   		"                 [ loss gemodel PERCENT [R [1-H [1-K]]]\n"
>>> +		"                 [ seed SEED \n]"
>> The newline seems misplaced.
>
> Sorry for that, I don't know how I could have missed that.
> Should I send a patch to fix this ?

That would be the way to get it fixed, yes.