Subject: Re: [PATCH net-next 1/3] rtnl: allocate more attr tables on the heap

From: Kalle Valo <[email-masked]>
Date: Sat, 30 Apr 2022 10:32:25 +0300

Jakub Kicinski <[email-masked]> writes:

> Commit a293974590cf ("rtnetlink: avoid frame size warning in rtnl_newlink()")
> moved to allocating the largest attribute array of rtnl_newlink()
> on the heap. Kalle reports the stack has grown above 1k again:
>
>   net/core/rtnetlink.c:3557:1: error: the frame size of 1104 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
>
> Move more attrs to the heap, wrap them in a struct.
> Don't bother with linkinfo, it's referenced a lot and we take
> its size so it's awkward to move, plus it's small (6 elements).
>
> Reported-by: Kalle Valo <[email-masked]>
> Signed-off-by: Jakub Kicinski <[email-masked]>

I don't see the warning anymore, thanks!

Tested-by: Kalle Valo <[email-masked]>

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches