From: Petr Machata <petrm@nvidia•com>
To: David Ahern <dsahern@gmail•com>
Cc: Petr Machata <petrm@nvidia•com>, <netdev@vger•kernel.org>,
"Stephen Hemminger" <stephen@networkplumber•org>,
Maksym Yaremchuk <maksymy@nvidia•com>
Subject: Re: [PATCH iproute2] dcb: app: Add missing "dcb app show dev X default-prio"
Date: Wed, 19 Jan 2022 11:38:54 +0100 [thread overview]
Message-ID: <87pmooove2.fsf@nvidia.com> (raw)
In-Reply-To: <0758f5ce-2461-95c2-edc0-9a24e44671d3@gmail.com>
David Ahern <dsahern@gmail•com> writes:
> On 1/18/22 4:36 AM, Petr Machata wrote:
>> All the actual code exists, but we neglect to recognize "default-prio" as a
>> CLI key for selection of what to show.
>>
>> Reported-by: Maksym Yaremchuk <maksymy@nvidia•com>
>> Tested-by: Maksym Yaremchuk <maksymy@nvidia•com>
>> Signed-off-by: Petr Machata <petrm@nvidia•com>
>> ---
>> dcb/dcb_app.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/dcb/dcb_app.c b/dcb/dcb_app.c
>> index 28f40614..54a95a07 100644
>> --- a/dcb/dcb_app.c
>> +++ b/dcb/dcb_app.c
>> @@ -646,6 +646,8 @@ static int dcb_cmd_app_show(struct dcb *dcb, const char *dev, int argc, char **a
>> goto out;
>> } else if (matches(*argv, "ethtype-prio") == 0) {
>> dcb_app_print_ethtype_prio(&tab);
>> + } else if (matches(*argv, "default-prio") == 0) {
>> + dcb_app_print_default_prio(&tab);
>> } else if (matches(*argv, "dscp-prio") == 0) {
>> dcb_app_print_dscp_prio(dcb, &tab);
>> } else if (matches(*argv, "stream-port-prio") == 0) {
>
> In general, we are not allowing more uses of matches(). I think this one
> can be an exception for consistency with the other options, so really
> just a heads up.
The shortening that the matches() allows is very useful for typing. I do
stuff like "ip l sh dev X up" and "ip a a dev X 192.0.2.1/28" all the
time. I suppose there was a discussion about this, can you point me at
the thread, or where & when approximately it took place so I can look it
up?
next prev parent reply other threads:[~2022-01-19 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 11:36 [PATCH iproute2] dcb: app: Add missing "dcb app show dev X default-prio" Petr Machata
2022-01-19 2:44 ` David Ahern
2022-01-19 10:38 ` Petr Machata [this message]
2022-01-19 20:35 ` Stephen Hemminger
2022-01-19 23:39 ` David Ahern
2022-01-19 20:36 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmooove2.fsf@nvidia.com \
--to=petrm@nvidia$(echo .)com \
--cc=dsahern@gmail$(echo .)com \
--cc=maksymy@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox