Subject: Re: [PATCH V4 mlx5-next 06/13] vfio: Fix VFIO_DEVICE_STATE_SET_ERROR macro

From: Cornelia Huck <[email-masked]>
Date: Tue, 26 Oct 2021 17:32:19 +0200

On Tue, Oct 26 2021, Yishai Hadas <[email-masked]> wrote:

> Fixed the non-compiled macro VFIO_DEVICE_STATE_SET_ERROR (i.e. SATE
> instead of STATE).
>
> Fixes: a8a24f3f6e38 ("vfio: UAPI for migration interface for device state")
> Signed-off-by: Yishai Hadas <[email-masked]>
> Signed-off-by: Leon Romanovsky <[email-masked]>

This s-o-b chain looks weird; your s-o-b always needs to be last.

> ---
>  include/uapi/linux/vfio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
> index ef33ea002b0b..114ffcefe437 100644
> --- a/include/uapi/linux/vfio.h
> +++ b/include/uapi/linux/vfio.h
> @@ -622,7 +622,7 @@ struct vfio_device_migration_info {
>  					      VFIO_DEVICE_STATE_RESUMING))
>  
>  #define VFIO_DEVICE_STATE_SET_ERROR(state) \
> -	((state & ~VFIO_DEVICE_STATE_MASK) | VFIO_DEVICE_SATE_SAVING | \
> +	((state & ~VFIO_DEVICE_STATE_MASK) | VFIO_DEVICE_STATE_SAVING | \
>  					     VFIO_DEVICE_STATE_RESUMING)
>  
>  	__u32 reserved;

Change looks fine, although we might consider merging it with the next
patch? Anyway,

Reviewed-by: Cornelia Huck <[email-masked]>