public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@intel•com>
To: Vladimir Oltean <vladimir.oltean@nxp•com>,
	Xiaoliang Yang <xiaoliang.yang_1@nxp•com>
Cc: "davem@davemloft•net" <davem@davemloft•net>,
	"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
	"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
	"Arvid.Brodin@xdin•com" <Arvid.Brodin@xdin•com>,
	"m-karicheri2@ti•com" <m-karicheri2@ti•com>,
	"michael.chan@broadcom•com" <michael.chan@broadcom•com>,
	"vishal@chelsio•com" <vishal@chelsio•com>,
	"saeedm@mellanox•com" <saeedm@mellanox•com>,
	"jiri@mellanox•com" <jiri@mellanox•com>,
	"idosch@mellanox•com" <idosch@mellanox•com>,
	"alexandre.belloni@bootlin•com" <alexandre.belloni@bootlin•com>,
	"ivan.khoronzhuk@linaro•org" <ivan.khoronzhuk@linaro•org>,
	"andre.guedes@linux•intel.com" <andre.guedes@linux•intel.com>,
	"allan.nielsen@microchip•com" <allan.nielsen@microchip•com>,
	"joergen.andreasen@microchip•com"
	<joergen.andreasen@microchip•com>,
	"jhs@mojatatu•com" <jhs@mojatatu•com>
Subject: Re: [EXT] Re: [RFC, net-next] net: qos: introduce a frer action to implement 802.1CB
Date: Fri, 01 Oct 2021 10:13:44 -0700	[thread overview]
Message-ID: <87pmsofz1z.fsf@intel.com> (raw)
In-Reply-To: <20211001161710.2sdz6o6lh3yg7k6p@skbuf>

Hi Vladimir,

Vladimir Oltean <vladimir.oltean@nxp•com> writes:

> Hi Vinicius,
>
> On Wed, Sep 29, 2021 at 10:25:58AM +0000, Xiaoliang Yang wrote:
>> Hi Vinicius,
>>
>> On Sep 29, 2021 at 6:35:59 +0000, Vinicius Costa Gomes wrote:
>> > > This patch introduce a frer action to implement frame replication and
>> > > elimination for reliability, which is defined in IEEE P802.1CB.
>> > >
>> >
>> > An action seems, to me, a bit too limiting/fine grained for a frame replication
>> > and elimination feature.
>> >
>> > At least I want to hear the reasons that the current hsr/prp support cannot be
>> > extended to support one more tag format/protocol.
>> >
>> > And the current name for the spec is IEEE 802.1CB-2017.
>> >
>> 802.1CB can be set on bridge ports, and need to use bridge forward
>> Function as a relay system. It only works on identified streams,
>> unrecognized flows still need to pass through the bridged network
>> normally.
>>
>> But current hsr/prp seems only support two ports, and cannot use the
>> ports in bridge. It's hard to implement FRER functions on current HSR
>> driver.
>>
>> You can see chapter "D.2 Example 2: Various stack positions" in IEEE 802.1CB-2017,
>> Protocol stack for relay system is like follows:
>>
>>              Stream Transfer Function
>>                 |             |
>>                 |        Sequence generation
>>                 |            Sequence encode/decode
>>   Stream identification        Active Stream identification
>>                 |              |
>>                 |        Internal LAN---- Relay system forwarding
>>                 |                        |        |
>>                 MAC                    MAC        MAC
>>
>> Use port actions to easily implement FRER tag add/delete, split, and
>> recover functions.
>>
>> Current HSR/PRP driver can be used for port HSR/PRP set, and tc-frer
>> Action to be used for stream RTAG/HSR/PRP set and recover.
>
> Did Xiaoliang answer your question satisfactorily? :)

Oh, yes, the answer was very good. I was taking some time to read the
802.1CB spec, and try to think how things would fit together so I can
ask better questions next time :-)


Cheers,
-- 
Vinicius

  reply	other threads:[~2021-10-01 17:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 11:44 [RFC, net-next] net: qos: introduce a frer action to implement 802.1CB Xiaoliang Yang
2021-09-28 22:34 ` Vinicius Costa Gomes
2021-09-29 10:25   ` [EXT] " Xiaoliang Yang
2021-10-01 16:17     ` Vladimir Oltean
2021-10-01 17:13       ` Vinicius Costa Gomes [this message]
2021-10-01 17:27     ` Vinicius Costa Gomes
2021-10-01 17:55       ` Vladimir Oltean
2021-10-01 18:11         ` Vladimir Oltean
2021-10-01 22:56         ` Vinicius Costa Gomes
2021-10-04 18:52 ` Vinicius Costa Gomes
2022-05-06 11:55 ` Ferenc Fejes
2022-05-06 12:23   ` Vladimir Oltean
2022-05-06 14:44     ` Ferenc Fejes
2022-05-06 19:31       ` Vladimir Oltean
2022-05-09 11:27         ` István Moldován

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmsofz1z.fsf@intel.com \
    --to=vinicius.gomes@intel$(echo .)com \
    --cc=Arvid.Brodin@xdin$(echo .)com \
    --cc=alexandre.belloni@bootlin$(echo .)com \
    --cc=allan.nielsen@microchip$(echo .)com \
    --cc=andre.guedes@linux$(echo .)intel.com \
    --cc=davem@davemloft$(echo .)net \
    --cc=idosch@mellanox$(echo .)com \
    --cc=ivan.khoronzhuk@linaro$(echo .)org \
    --cc=jhs@mojatatu$(echo .)com \
    --cc=jiri@mellanox$(echo .)com \
    --cc=joergen.andreasen@microchip$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=m-karicheri2@ti$(echo .)com \
    --cc=michael.chan@broadcom$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=saeedm@mellanox$(echo .)com \
    --cc=vishal@chelsio$(echo .)com \
    --cc=vladimir.oltean@nxp$(echo .)com \
    --cc=xiaoliang.yang_1@nxp$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox