Subject: Re: [PATCH iproute2 v3 1/1] build: Fix link errors on some systems

From: Petr Machata <[email-masked]>
Date: Mon, 11 Jan 2021 17:51:39 +0100

Roi Dayan <[email-masked]> writes:

> diff --git a/lib/json_print_math.c b/lib/json_print_math.c
> new file mode 100644
> index 000000000000..3d560defcd3e
> --- /dev/null
> +++ b/lib/json_print_math.c
> @@ -0,0 +1,46 @@
> +/*
> + * json_print_math.c		"print regular or json output, based on json_writer".
> + *
> + *             This program is free software; you can redistribute it and/or
> + *             modify it under the terms of the GNU General Public License
> + *             as published by the Free Software Foundation; either version
> + *             2 of the License, or (at your option) any later version.
> + *

This should have a SPDX tag instead of the license excerpt:

// SPDX-License-Identifier: GPL-2.0+

> + * Authors:    Julien Fortin, <[email-masked]>
> + */

sprint_size() comes from TC and predates iproute2 git repo (2004),
whereas Cumulus Networks was around from 2010. So the authorship
declaration is likely inaccurate. I think it's also unnecessary, and
would just drop it.

> diff --git a/lib/utils_math.c b/lib/utils_math.c
> new file mode 100644
> index 000000000000..d67affeb16c2
> --- /dev/null
> +++ b/lib/utils_math.c
> @@ -0,0 +1,133 @@
> +/*
> + * utils.c
> + *
> + *		This program is free software; you can redistribute it and/or
> + *		modify it under the terms of the GNU General Public License
> + *		as published by the Free Software Foundation; either version
> + *		2 of the License, or (at your option) any later version.
> + *
> + * Authors:	Alexey Kuznetsov, <[email-masked]>

The same here re license and authorship. The latter might in fact be
accurate in this case, but I would still drop it :)

Otherwise this looks good to me.