From: Sven Joachim <svenjoac@gmx•de>
To: Stephen Hemminger <shemminger@vyatta•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH 1/6] sky2: fix hang on shutdown (and other irq issues)
Date: Thu, 17 Nov 2011 19:37:58 +0100 [thread overview]
Message-ID: <87pqgqoard.fsf@turtle.gmx.de> (raw)
In-Reply-To: <20111117090104.002e110a@s6510.linuxnetplumber.net> (Stephen Hemminger's message of "Thu, 17 Nov 2011 09:01:04 -0800")
On 2011-11-17 18:01 +0100, Stephen Hemminger wrote:
> On Thu, 17 Nov 2011 09:46:43 +0100
> Sven Joachim <svenjoac@gmx•de> wrote:
>
>> On 2011-11-17 00:42 +0100, Stephen Hemminger wrote:
>>
>> > There are several problems with recent change to how IRQ's are setup.
>> > * synchronize_irq in sky2_shutdown would hang because there
>> > was no IRQ setup.
>> > * when device was set to down, some IRQ bits left enabled so a
>> > hardware error would produce IRQ with no handler
>> > * quick link on Optima chip set was enabled without handler
>> > * suspend/resume would leave IRQ on with no handler if device
>> > was down
>>
>> Unfortunately, this patch does not fix the hang at shutdown for me. :-(
>
> You are probably stuck in some part of the code path in sky2_shutdown.
Indeed.
> The best debug for this is sprinkling the code printk's. That is how I
> narrowed the problem down to synchronize_irq.
So I found out it's hanging in napi_disable() in sky2_all_down(). Not
being a kernel hacker, I don't know where to go from there.
Cheers,
Sven
next prev parent reply other threads:[~2011-11-17 18:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 23:42 [PATCH 0/6] sky2 patches for net-next Stephen Hemminger
2011-11-16 23:42 ` [PATCH 1/6] sky2: fix hang on shutdown (and other irq issues) Stephen Hemminger
2011-11-17 8:46 ` Sven Joachim
2011-11-17 17:01 ` Stephen Hemminger
2011-11-17 18:37 ` Sven Joachim [this message]
2011-11-17 19:18 ` Stephen Hemminger
2011-11-17 20:57 ` Sven Joachim
2011-11-18 0:37 ` [PATCH net-next] sky2: fix hang in napi_disable Stephen Hemminger
2011-11-18 1:52 ` David Miller
2011-11-18 2:10 ` Stephen Hemminger
2011-11-18 2:15 ` David Miller
2011-11-18 2:44 ` David Miller
2011-11-16 23:42 ` [PATCH 2/6] sky2: pci posting issues Stephen Hemminger
2011-11-16 23:42 ` [PATCH 3/6] sky2: rename up/down functions Stephen Hemminger
2011-11-16 23:42 ` [PATCH 4/6] sky2: reduce default Tx ring size Stephen Hemminger
2011-11-17 21:07 ` Sven Joachim
2011-11-17 22:41 ` Stephen Hemminger
2011-11-18 0:37 ` [PATCH net-next] sky2: enforce minimum " Stephen Hemminger
2011-11-18 2:44 ` David Miller
2011-11-16 23:42 ` [PATCH 5/6] sky2: used fixed RSS key Stephen Hemminger
2011-11-16 23:43 ` [PATCH 6/6] sky2: version 1.30 Stephen Hemminger
2011-11-17 1:36 ` [PATCH 0/6] sky2 patches for net-next David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqgqoard.fsf@turtle.gmx.de \
--to=svenjoac@gmx$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox