Subject: Re: [PATCH 2/3] TI Davinci EMAC : add platform specific interrupt enable/disable logic.

From: Kevin Hilman <[email-masked]>
Date: Wed, 18 Nov 2009 14:29:54 -0800

Troy Kisky <[email-masked]> writes:

> Sriramakrishnan wrote:
>> On certain SOCs, the EMAC controller is interfaced with a wrapper logic
>> for handling interrupts. This  patch implements a platform
>> specific hook to cater to platforms that require custom interrupt
>> handling logic
>> 
>> Signed-off-by: Sriramakrishnan <[email-masked]>
>> Acked-by: Chaithrika U S <[email-masked]>
>> ---
>>  drivers/net/davinci_emac.c   |   11 +++++++++++
>>  include/linux/davinci_emac.h |    2 ++
>>  2 files changed, 13 insertions(+), 0 deletions(-)
>> 
>> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
>> index 6aec8f5..81931f8 100644
>> --- a/drivers/net/davinci_emac.c
>> +++ b/drivers/net/davinci_emac.c
>> @@ -487,6 +487,9 @@ struct emac_priv {
>>  	struct mii_bus *mii_bus;
>>  	struct phy_device *phydev;
>>  	spinlock_t lock;
>> +	/*platform specific members*/
>> +	void (*wrapper_int_enable) (void);
>> +	void (*wrapper_int_disable) (void);
>
> Would platform_int_enable be more appropriate then wrapper_int_enable ?
>

Or just int_enable.  As it's being used through a private pointer,
it's clear that it's a wrapper.

Kevin