Subject: Re: [PATCH] wifi: ath9k: don't allow to overwrite ENDPOINT0 attributes

From: Toke Høiland-Jørgensen <[email-masked]>
Date: Mon, 15 May 2023 14:15:37 +0200

Fedor Pchelkin <[email-masked]> writes:

> A bad USB device is able to construct a service connection response
> message with target endpoint being ENDPOINT0 which is reserved for
> HTC_CTRL_RSVD_SVC and should not be modified to be used for any other
> services.
>
> Reject such service connection responses.
>
> Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
>
> Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
> Reported-by: [email-masked]
> Signed-off-by: Fedor Pchelkin <[email-masked]>
> ---
>  drivers/net/wireless/ath/ath9k/htc_hst.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c
> index fe62ff668f75..a15d8d80df87 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_hst.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_hst.c
> @@ -114,7 +114,7 @@ static void htc_process_conn_rsp(struct htc_target *target,
>  
>  	if (svc_rspmsg->status == HTC_SERVICE_SUCCESS) {
>  		epid = svc_rspmsg->endpoint_id;
> -		if (epid < 0 || epid >= ENDPOINT_MAX)
> +		if (epid <= 0 || epid >= ENDPOINT_MAX)
>  			return;

Hmm, I think we should use the ENDPOINT0 constant here, then, and maybe
add a comment above explaining that it's reserved?

-Toke