From: Petr Machata <petrm@nvidia•com>
To: Petr Machata <petrm@nvidia•com>
Cc: David Ahern <dsahern@kernel•org>,
Daniel Machon <daniel.machon@microchip•com>,
<netdev@vger•kernel.org>, <stephen@networkplumber•org>,
<maxime.chevallier@bootlin•com>, <vladimir.oltean@nxp•com>,
<UNGLinuxDriver@microchip•com>
Subject: Re: [PATCH iproute2-next v2 1/2] dcb: add new pcp-prio parameter to dcb app
Date: Thu, 1 Dec 2022 15:10:00 +0100 [thread overview]
Message-ID: <87r0xjdxis.fsf@nvidia.com> (raw)
In-Reply-To: <87cz93fky0.fsf@nvidia.com>
Petr Machata <petrm@nvidia•com> writes:
> David Ahern <dsahern@kernel•org> writes:
>
>> On 11/28/22 5:38 AM, Daniel Machon wrote:
>>> @@ -344,6 +420,17 @@ static int dcb_app_print_key_dscp(__u16 protocol)
>>> return print_uint(PRINT_ANY, NULL, "%d:", protocol);
>>> }
>>>
>>> +static int dcb_app_print_key_pcp(__u16 protocol)
>>> +{
>>> + /* Print in numerical form, if protocol value is out-of-range */
>>> + if (protocol > 15) {
>>
>> 15 is used in a number of places in this patch. What's the significance
>> and can you give it a name that identifies the meaning?
>
> Here in particular, it is ARRAY_LENGTH(pcp_names), and I agree, it would
> be better to express it this way.
(protocol >= ARRAY_LENGTH(pcp_names) obviously, not >)
next prev parent reply other threads:[~2022-12-01 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 12:38 [PATCH iproute2-next v2 0/2] Add pcp-prio and new apptrust subcommand Daniel Machon
2022-11-28 12:38 ` [PATCH iproute2-next v2 1/2] dcb: add new pcp-prio parameter to dcb app Daniel Machon
2022-11-29 9:35 ` Petr Machata
2022-12-01 6:43 ` David Ahern
2022-12-01 10:57 ` Petr Machata
2022-12-01 14:10 ` Petr Machata [this message]
2022-12-02 8:45 ` Daniel.Machon
2022-11-28 12:38 ` [PATCH iproute2-next v2 2/2] dcb: add new subcommand for apptrust Daniel Machon
2022-11-29 9:24 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0xjdxis.fsf@nvidia.com \
--to=petrm@nvidia$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=daniel.machon@microchip$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox