Subject: Re: [PATCH v2 4/4] bus: Make remove callback return void

From: Cornelia Huck <[email-masked]>
Date: Tue, 06 Jul 2021 18:09:17 +0200

On Tue, Jul 06 2021, Uwe Kleine-König <[email-masked]> wrote:

> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
>
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
>
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
>
> Acked-by: Russell King (Oracle) <[email-masked]> (For ARM, Amba and related parts)
> Acked-by: Mark Brown <[email-masked]>
> Acked-by: Chen-Yu Tsai <[email-masked]> (for drivers/bus/sunxi-rsb.c)
> Acked-by: Pali Rohár <[email-masked]>
> Acked-by: Mauro Carvalho Chehab <[email-masked]> (for drivers/media)
> Acked-by: Hans de Goede <[email-masked]> (For drivers/platform)
> Acked-by: Alexandre Belloni <[email-masked]>
> Acked-By: Vinod Koul <[email-masked]>
> Acked-by: Juergen Gross <[email-masked]> (For Xen)
> Acked-by: Lee Jones <[email-masked]> (For drivers/mfd)
> Acked-by: Johannes Thumshirn <[email-masked]> (For drivers/mcb)
> Acked-by: Johan Hovold <[email-masked]>
> Acked-by: Srinivas Kandagatla <[email-masked]> (For drivers/slimbus)
> Acked-by: Kirti Wankhede <[email-masked]> (For drivers/vfio)
> Acked-by: Maximilian Luz <[email-masked]>
> Acked-by: Heikki Krogerus <[email-masked]> (For ulpi and typec)
> Acked-by: Samuel Iglesias Gonsálvez <[email-masked]> (For ipack)
> Reviewed-by: Tom Rix <[email-masked]> (For fpga)
> Acked-by: Geoff Levand <[email-masked]> (For ps3)
> Signed-off-by: Uwe Kleine-König <[email-masked]>
> ---
>
>  drivers/s390/cio/ccwgroup.c               | 4 +---
>  drivers/s390/cio/css.c                    | 4 +---
>  drivers/s390/cio/device.c                 | 4 +---
>  drivers/s390/cio/scm.c                    | 4 +---
>  drivers/s390/crypto/ap_bus.c              | 4 +---
>  drivers/vfio/mdev/mdev_driver.c           | 4 +---

For drivers/s390 and drivers/vfio:

Reviewed-by: Cornelia Huck <[email-masked]>