Subject: Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

From: Kalle Valo <[email-masked]>
Date: Fri, 14 Aug 2020 18:15:39 +0300

Lee Jones <[email-masked]> writes:

>  - Ensure spaces appear after {for, if, while, etc}
>  - Ensure spaces to not appear after '('
>  - Ensure spaces to not appear before ')'
>  - Ensure spaces appear between ')' and '{'
>  - Ensure spaces appear after ','
>  - Ensure spaces do not appear before ','
>  - Ensure spaces appear either side of '='
>  - Ensure '{'s which open functions are on a new line
>  - Remove trailing whitespace
>
> There are still a whole host of issues with this file, but this
> patch certainly breaks the back of them.
>
> Cc: Kalle Valo <[email-masked]>
> Cc: "David S. Miller" <[email-masked]>
> Cc: Jakub Kicinski <[email-masked]>
> Cc: Benjamin Reed <[email-masked]>
> Cc: Javier Achirica <[email-masked]>
> Cc: Jean Tourrilhes <[email-masked]>
> Cc: Fabrice Bellet <[email-masked]>
> Cc: [email-masked]
> Cc: [email-masked]
> Signed-off-by: Lee Jones <[email-masked]>
> ---
>  drivers/net/wireless/cisco/airo.c | 897 ++++++++++++++++--------------
>  1 file changed, 467 insertions(+), 430 deletions(-)

This is a driver for ancient hardware, I'm not sure if it's worth trying
to fix any style issues. Is anyone even using it? Should we instead just
remove the driver?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches