From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: David Ahern <dsahern@gmail•com>, David Ahern <dsahern@kernel•org>,
netdev@vger•kernel.org
Cc: davem@davemloft•net, kuba@kernel•org, brouer@redhat•com,
daniel@iogearbox•net, john.fastabend@gmail•com, ast@kernel•org,
kafai@fb•com, songliubraving@fb•com, yhs@fb•com, andriin@fb•com
Subject: Re: [PATCH bpf-next 2/5] bpf: Add support to attach bpf program to a devmap entry
Date: Wed, 27 May 2020 16:58:46 +0200 [thread overview]
Message-ID: <87r1v51l21.fsf@toke.dk> (raw)
In-Reply-To: <39fc3e35-49c6-3d47-e3fc-809f41998362@gmail.com>
David Ahern <dsahern@gmail•com> writes:
> On 5/27/20 4:01 AM, Toke Høiland-Jørgensen wrote:
>> Did you give any special consideration to where the hook should be? I'm
>> asking because my immediate thought was that it should be on flush
>> (i.e., in bq_xmit_all()), but now that I see this I'm so sure anymore.
>> What were your thoughts around this?
>
> I chose this spot for many reasons:
>
> 1. dev_map_enqueue has the bpf_dtab_netdev structure which holds the program
>
> 2. programs take xdp_buff, and dev_map_enqueue still has the xdp_buff
> with the rx information; no need to convert from buff to frame losing rx
> data, enqueue, back to buff to run program, back to frame to hand off to
> the driver.
>
> 3. no sense enqueuing if the device program drops the frame.
Right, makes sense; thank you for explaining :)
-Toke
next prev parent reply other threads:[~2020-05-27 14:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 1:09 [PATCH bpf-next 0/5] bpf: Add support for XDP programs in DEVMAP entries David Ahern
2020-05-27 1:09 ` [PATCH bpf-next 1/5] bpf: Handle 8-byte values in DEVMAP and DEVMAP_HASH David Ahern
2020-05-27 10:26 ` Jesper Dangaard Brouer
2020-05-27 13:56 ` David Ahern
2020-05-27 14:57 ` Toke Høiland-Jørgensen
2020-05-27 15:24 ` David Ahern
2020-05-27 14:27 ` David Ahern
2020-05-27 15:30 ` Jesper Dangaard Brouer
2020-05-27 18:38 ` David Ahern
2020-05-27 1:09 ` [PATCH bpf-next 2/5] bpf: Add support to attach bpf program to a devmap entry David Ahern
2020-05-27 10:01 ` Toke Høiland-Jørgensen
2020-05-27 14:02 ` David Ahern
2020-05-27 14:58 ` Toke Høiland-Jørgensen [this message]
2020-05-27 1:09 ` [PATCH bpf-next 3/5] xdp: Add xdp_txq_info to xdp_buff David Ahern
2020-05-27 1:09 ` [PATCH bpf-next 4/5] bpftool: Add SEC name for xdp programs attached to device map David Ahern
2020-05-27 10:02 ` Toke Høiland-Jørgensen
2020-05-27 14:03 ` David Ahern
2020-05-27 15:01 ` Toke Høiland-Jørgensen
2020-05-27 15:43 ` Jesper Dangaard Brouer
2020-05-27 1:09 ` [PATCH bpf-next 5/5] selftest: Add tests for XDP programs in devmap entries David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1v51l21.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=andriin@fb$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=brouer@redhat$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kafai@fb$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=songliubraving@fb$(echo .)com \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox