Subject: Re: [PATCH] rtlwifi: rtl8821ae: add in a missing break in switch statement

From: Kalle Valo <[email-masked]>
Date: Sat, 06 Oct 2018 22:30:13 +0300

Colin King <[email-masked]> writes:

> From: Colin Ian King <[email-masked]>
>
> The switch case RATR_INX_WIRELESS_MC has a missing break, this seems
> to be unintentional as the setting of variable ret gets overwritten
> when the case falls through to the following RATR_INX_WIRELESS_AC_5N
> case.  Fix this by adding in the missing break.
>
> Detected by CoverityScan, CID#1167237 ("Missing break in switch")
>
> Fixes: 3c05bedb5fef ("Staging: rtl8812ae: Add Realtek 8821 PCI WIFI driver")
> Signed-off-by: Colin Ian King <[email-masked]>
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 1 +

Is the fixes line correct? This patch is not for staging.

-- 
Kalle Valo