From: "Valo, Kalle" <kvalo@qca•qualcomm.com>
To: Bjorn Andersson <bjorn.andersson@linaro•org>
Cc: "k.eugene.e@gmail•com" <k.eugene.e@gmail•com>,
Andy Gross <andy.gross@linaro•org>,
"wcn36xx@lists•infradead.org" <wcn36xx@lists•infradead.org>,
"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-arm-msm@vger•kernel.org" <linux-arm-msm@vger•kernel.org>
Subject: Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()
Date: Thu, 1 Dec 2016 10:17:56 +0000 [thread overview]
Message-ID: <87r35srm0c.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <874m2otenv.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Thu, 01 Dec 2016 07:13:40 +0200")
Kalle Valo <kvalo@qca•qualcomm.com> writes:
> Kalle Valo <kvalo@qca•qualcomm.com> writes:
>
>> "Valo, Kalle" <kvalo@qca•qualcomm.com> writes:
>>
>>> Bjorn Andersson <bjorn.andersson@linaro•org> writes:
>>>
>>>> On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote:
>>>>
>>>>> Bjorn Andersson <bjorn.andersson@linaro•org> wrote:
>>>>> > The correct include file for getting errno constants and ERR_PTR() is
>>>>> > linux/err.h, rather than linux/errno.h, so fix the include.
>>>>> >
>>>>> > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state")
>>>>> > Acked-by: Andy Gross <andy.gross@linaro•org>
>>>>> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro•org>
>>>>>
>>>>> For some reason this fails to compile now. Can you take a look, please?
>>>>>
>>>>> ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined!
>>>>> make[1]: *** [__modpost] Error 1
>>>>> make: *** [modules] Error 2
>>>>>
>>>>> 5 patches set to Changes Requested.
>>>>>
>>>>> 9429045 [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()
>>>>> 9429047 [v5,2/5] wcn36xx: Transition driver to SMD client
>>>>
>>>> This patch was updated with the necessary depends in Kconfig to catch
>>>> this exact issue and when I pull in your .config (which has QCOM_SMD=n,
>>>> QCOM_WCNSS_CTRL=n and WCN36XX=y) I can build this just fine.
>>>>
>>>> I've tested the various combinations and it seems to work fine. Do you
>>>> have any other patches in your tree?
>>>
>>> This was with the pending branch of my ath.git tree. There are other
>>> wireless patches (ath10k etc) but I would guess they don't affect here.
>>>
>>>> Any stale objects?
>>>
>>> Not sure what you mean with this question, but I didn't run 'make clean'
>>> if that's what you are asking.
>>>
>>>> Would you mind retesting this, before I invest more time in trying to
>>>> reproduce the issue you're seeing?
>>>
>>> Sure, I'll take a look but that might take few days.
>>
>> I didn't find enough time to look at this in detail. I applied this to
>> my ath.git pending branch, let's see what the kbuild bot finds.
>
> It found the same problem. Interestingly I'm also building x86 with 32
> bit, maybe it's related?
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
> head: 1ea16a1c457939b4564643f7637d5cc639a8d3b7
> commit: 5eb09c672b01460804fd49b1c9cc7d1072a102f0 [96/99] wcn36xx: Transition driver to SMD client
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> git checkout 5eb09c672b01460804fd49b1c9cc7d1072a102f0
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
>>> ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined!
Bjorn mentioned me on IRC that this is because of a missing commit in my
tree:
daa6e41ce2b5 soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API
When I pull the tag below (which contains the above commit) wcn36xx
builds fine for me:
git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-drivers-for-4.10
Andy, is it ok if I pull your tag also to my ath.git tree to solve the
wcn36xx build problem? My trees go to Linus via net-next and I don't
know when exactly Dave would send a pull request to Linus, before or
after the arm trees, but as the tag seems to contain only few patches I
hope it doesn't matter.
--
Kalle Valo
next prev parent reply other threads:[~2016-12-01 10:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 6:06 [PATCH v5 1/5] soc: qcom: smem_state: Fix include for ERR_PTR() Bjorn Andersson
2016-11-15 6:06 ` [PATCH v5 2/5] wcn36xx: Transition driver to SMD client Bjorn Andersson
[not found] ` <1479190014-11297-1-git-send-email-bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-11-15 6:06 ` [PATCH v5 3/5] wcn36xx: Implement firmware assisted scan Bjorn Andersson
2016-11-15 6:06 ` [PATCH v5 4/5] wcn36xx: Implement print_reg indication Bjorn Andersson
2016-11-15 6:06 ` [PATCH v5 5/5] wcn36xx: Don't use the destroyed hal_mutex Bjorn Andersson
2016-11-16 18:49 ` [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() Kalle Valo
2016-11-16 18:54 ` Valo, Kalle
2016-11-18 18:35 ` Bjorn Andersson
2016-11-22 14:55 ` Valo, Kalle
2016-11-30 18:40 ` Valo, Kalle
2016-12-01 5:13 ` Valo, Kalle
2016-12-01 10:17 ` Valo, Kalle [this message]
[not found] ` <87r35srm0c.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2016-12-01 14:21 ` Andy Gross
2016-12-05 11:45 ` Valo, Kalle
2017-01-12 10:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r35srm0c.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca$(echo .)qualcomm.com \
--cc=andy.gross@linaro$(echo .)org \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=k.eugene.e@gmail$(echo .)com \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wcn36xx@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox