Subject: Re: [PATCH v2 1/1] dt-bindings: net: wireless: convert marvel-8xxx.txt to yaml format

From: Kalle Valo <[email-masked]>
Date: Tue, 20 Aug 2024 12:17:51 +0300

Brian Norris <[email-masked]> writes:

> Hi Frank,
>
> On Fri, Aug 16, 2024 at 01:12:01PM -0400, Frank Li wrote:
>> Convert binding doc marvel-8xxx.txt to yaml format.
>> Additional change:
>> - Remove marvell,caldata_00_txpwrlimit_2g_cfg_set in example.
>> - Remove mmc related property in example.
>> - Add wakeup-source property.
>> - Remove vmmc-supply and mmc-pwrseq.
>> 
>> Fix below warning:
>> arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dtb: /soc@0/bus@30800000/mmc@30b40000/wifi@1:
>> failed to match any schema with compatible: ['marvell,sd8997']
>> 
>> Signed-off-by: Frank Li <[email-masked]>
>> ---
>> Change from v1 to v2
>> - Add Brian Norris <[email-masked] as maintainer
>> - Remove vmmc-supply and mmc-pwrseq
>> - Add wakeup-source
>> - rename to marvell,sd8787.yaml by using one compatible string, suggestted
>> by conor dooley at other binding doc convert review
>> ---
>>  .../bindings/net/wireless/marvell,sd8787.yaml | 93 +++++++++++++++++++
>>  .../bindings/net/wireless/marvell-8xxx.txt    | 70 --------------
>>  2 files changed, 93 insertions(+), 70 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml
>>  delete mode 100644 Documentation/devicetree/bindings/net/wireless/marvell-8xxx.txt
>> 
>> diff --git a/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml b/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml
>> new file mode 100644
>> index 0000000000000..c6647672b7b1e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml
>> @@ -0,0 +1,93 @@
>
>> +  marvell,caldata-txpwrlimit-5g-sub0:
>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>> +    description: Calibration data for sub-band 0 in the 5GHz band..
>
> You have an extra period in this line.
>
>> +  marvell,caldata-txpwrlimit-5g-sub1:
>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>> +    description: Calibration data for sub-band 1 in the 5GHz band..
>
> Same.
>
>> +    maxItems: 688
>> +
>> +  marvell,caldata-txpwrlimit-5g-sub2:
>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>> +    description: Calibration data for sub-band 2 in the 5GHz band..
>
> Same.
>
> Otherwise, this looks good to me, so feel free to carry my:
>
> Acked-by: Brian Norris <[email-masked]>
>
> (Sometimes Kalle will make trivial fixes like this when applying. I'm
> not sure if that means you should send v3 anyway, or see if he'll apply
> this on his own soon enough.)

For wireless-next patches I can easily edit commit messages but not the
actual patch, so please send v3.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches