From: Jakub Sitnicki <jakub@cloudflare•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: netdev@vger•kernel.org,
Willem de Bruijn <willemdebruijn.kernel@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
kernel-team@cloudflare•com
Subject: Re: [PATCH net-next v2] selftests: udpgso: Pull up network setup into shell script
Date: Wed, 07 Feb 2024 21:09:55 +0100 [thread overview]
Message-ID: <87sf24qbkp.fsf@cloudflare.com> (raw)
In-Reply-To: <20240207102410.7062dcb0@kernel.org>
On Wed, Feb 07, 2024 at 10:24 AM -08, Jakub Kicinski wrote:
> On Tue, 06 Feb 2024 19:58:31 +0100 Jakub Sitnicki wrote:
>> +setup_loopback() {
>> + ip addr add dev lo 10.0.0.1/32
>> + ip addr add dev lo fd00::1/128 nodad noprefixroute
>> +}
>
> Can I nit pick on stupid stuff?
> Quick look at other udpg*s*.sh scripts indicates we use tabs
> for indent. IDK what the rules should be but I have an uneducated
> feeling that 2 spaces are quite rare.
My oversight. ~/.editorconfig kicked in and I didn't notice.
Let me respin.
prev parent reply other threads:[~2024-02-07 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 18:58 [PATCH net-next v2] selftests: udpgso: Pull up network setup into shell script Jakub Sitnicki
2024-02-06 23:15 ` Willem de Bruijn
2024-02-07 18:24 ` Jakub Kicinski
2024-02-07 20:09 ` Jakub Sitnicki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf24qbkp.fsf@cloudflare.com \
--to=jakub@cloudflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kernel-team@cloudflare$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox