From: Petr Machata <petrm@nvidia•com>
To: Petr Machata <petrm@nvidia•com>
Cc: Daniel Machon <daniel.machon@microchip•com>,
<netdev@vger•kernel.org>, <dsahern@kernel•org>,
<stephen@networkplumber•org>, <maxime.chevallier@bootlin•com>,
<vladimir.oltean@nxp•com>, <UNGLinuxDriver@microchip•com>
Subject: Re: [PATCH iproute2-next 1/2] dcb: add new pcp-prio parameter to dcb app
Date: Thu, 24 Nov 2022 17:11:43 +0100 [thread overview]
Message-ID: <87sfi8ib6t.fsf@nvidia.com> (raw)
In-Reply-To: <87wn7kibn8.fsf@nvidia.com>
Petr Machata <petrm@nvidia•com> writes:
> This looks good to me overall, I just have a few nits.
>
> Daniel Machon <daniel.machon@microchip•com> writes:
>
>> Add new pcp-prio parameter to the app subcommand, which can be used to
>> classify traffic based on PCP and DEI from the VLAN header. PCP and DEI
>> is specified in a combination of numerical and symbolic form, where 'de'
>> (as specified in the PCP Encoding Table, 802.1Q) means DEI=1.
>>
>> Map PCP 1 and DEI 0 to priority 1 $ dcb app add dev eth0 pcp-prio 1:1
>>
>> Map PCP 1 and DEI 1 to priority 1 $ dcb app add dev eth0 pcp-prio 1de:1
>>
>> Internally, PCP and DEI is encoded in the protocol field of the dcb_app
>> struct. Each combination of PCP and DEI maps to a priority, thus needing
>> a range of 0-15. A well formed dcb_app entry for PCP/DEI
>> prioritization, could look like:
>>
>> struct dcb_app pcp = {
>> .selector = DCB_APP_SEL_PCP,
>> .priority = 7,
>> .protocol = 15
>> }
>>
>> For mapping PCP=7 and DEI=1 to Prio=7.
>>
>> Also, two helper functions for translating between std and non-std APP
>> selectors, have been added to dcb_app.c and exposed through dcb.h.
>
> Could you include an example or two of how PCP is configured? E.g. the
> following was part of the dcb-app submission:
>
> # dcb app add dev eni1np1 dscp-prio 0:0 CS3:3 CS6:6
> # dcb app show dev eni1np1
> dscp-prio 0:0 CS3:3 CS6:6
I just noticed you have the examples up there. Maybe just reformat them
a bit so that they stand out.
next prev parent reply other threads:[~2022-11-24 16:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 10:41 [PATCH iproute2-next 0/2] Add pcp-prio and new apptrust subcommand Daniel Machon
2022-11-22 10:41 ` [PATCH iproute2-next 1/2] dcb: add new pcp-prio parameter to dcb app Daniel Machon
2022-11-24 15:30 ` Petr Machata
2022-11-24 16:11 ` Petr Machata [this message]
2022-11-24 16:53 ` Petr Machata
2022-11-25 10:07 ` Daniel.Machon
2022-11-25 13:12 ` Petr Machata
2022-11-22 10:41 ` [PATCH iproute2-next 2/2] dcb: add new subcommand for apptrust Daniel Machon
2022-11-24 16:16 ` Petr Machata
2022-11-25 9:11 ` Daniel.Machon
2022-11-25 13:06 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfi8ib6t.fsf@nvidia.com \
--to=petrm@nvidia$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=daniel.machon@microchip$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox