From: Petr Machata <petrm@nvidia•com>
To: <trix@redhat•com>
Cc: <davem@davemloft•net>, <kuba@kernel•org>, <nathan@kernel•org>,
<ndesaulniers@google•com>, <idosch@nvidia•com>,
<petrm@nvidia•com>, <edumazet@google•com>, <avagin@gmail•com>,
<yajun.deng@linux•dev>, <johannes.berg@intel•com>,
<cong.wang@bytedance•com>, <netdev@vger•kernel.org>,
<linux-kernel@vger•kernel.org>, <llvm@lists•linux.dev>
Subject: Re: [PATCH] net: rtnetlink: fix error handling in rtnl_fill_statsinfo()
Date: Mon, 7 Mar 2022 10:43:28 +0100 [thread overview]
Message-ID: <87sfru9jwz.fsf@nvidia.com> (raw)
In-Reply-To: <20220305181346.697365-1-trix@redhat.com>
trix@redhat•com writes:
> From: Tom Rix <trix@redhat•com>
>
> The clang static analyzer reports this issue
> rtnetlink.c:5481:2: warning: Undefined or garbage
> value returned to caller
> return err;
> ^~~~~~~~~~
>
> There is a function level err variable, in the
> list_for_each_entry_rcu block there is a shadow
> err. Remove the shadow.
>
> In the same block, the call to nla_nest_start_noflag()
> can fail without setting an err. Set the err
> to -EMSGSIZE.
>
> Fixes: 216e690631f5 ("net: rtnetlink: rtnl_fill_statsinfo(): Permit non-EMSGSIZE error returns")
> Signed-off-by: Tom Rix <trix@redhat•com>
Reviewed-by: Petr Machata <petrm@nvidia•com>
Thanks!
next prev parent reply other threads:[~2022-03-07 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 18:13 [PATCH] net: rtnetlink: fix error handling in rtnl_fill_statsinfo() trix
2022-03-07 7:16 ` Ido Schimmel
2022-03-07 9:43 ` Petr Machata [this message]
2022-03-07 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfru9jwz.fsf@nvidia.com \
--to=petrm@nvidia$(echo .)com \
--cc=avagin@gmail$(echo .)com \
--cc=cong.wang@bytedance$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=johannes.berg@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=llvm@lists$(echo .)linux.dev \
--cc=nathan@kernel$(echo .)org \
--cc=ndesaulniers@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=trix@redhat$(echo .)com \
--cc=yajun.deng@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox