From: Thomas Gleixner <tglx@linutronix•de>
To: Nitesh Lal <nilal@redhat•com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel•com>,
"frederic\@kernel.org" <frederic@kernel•org>,
"juri.lelli\@redhat.com" <juri.lelli@redhat•com>,
Marcelo Tosatti <mtosatti@redhat•com>,
abelits@marvell•com, Robin Murphy <robin.murphy@arm•com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger•kernel.org>,
"linux-api\@vger.kernel.org" <linux-api@vger•kernel.org>,
"bhelgaas\@google.com" <bhelgaas@google•com>,
"linux-pci\@vger.kernel.org" <linux-pci@vger•kernel.org>,
"rostedt\@goodmis.org" <rostedt@goodmis•org>,
"mingo\@kernel.org" <mingo@kernel•org>,
"peterz\@infradead.org" <peterz@infradead•org>,
"davem\@davemloft.net" <davem@davemloft•net>,
"akpm\@linux-foundation.org" <akpm@linux-foundation•org>,
"sfr\@canb.auug.org.au" <sfr@canb•auug.org.au>,
"stephen\@networkplumber.org" <stephen@networkplumber•org>,
"rppt\@linux.vnet.ibm.com" <rppt@linux•vnet.ibm.com>,
"jinyuqi\@huawei.com" <jinyuqi@huawei•com>,
"zhangshaokun\@hisilicon.com" <zhangshaokun@hisilicon•com>,
netdev@vger•kernel.org, chris.friesen@windriver•com
Subject: Re: [Patch v4 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs
Date: Fri, 30 Apr 2021 20:21:33 +0200 [thread overview]
Message-ID: <87sg37eiqa.ffs@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAFki+LmmRyvOkWoNNLk5JCwtaTnabyaRUKxnS+wyAk_kj8wzyw@mail.gmail.com>
Nitesh,
On Fri, Apr 30 2021 at 12:14, Nitesh Lal wrote:
> Based on this analysis and the fact that with your re-work the interrupts
> seems to be naturally spread across the CPUs, will it be safe to revert
> Jesse's patch
>
> e2e64a932 genirq: Set initial affinity in irq_set_affinity_hint()
>
> as it overwrites the previously set IRQ affinity mask for some of the
> devices?
That's a good question. My gut feeling says yes.
> IMHO if we think that this patch is still solving some issue other than
> what Jesse has mentioned then perhaps we should reproduce that and fix it
> directly from the request_irq code path.
Makes sense.
Thanks,
tglx
next prev parent reply other threads:[~2021-04-30 18:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200625223443.2684-1-nitesh@redhat.com>
[not found] ` <20200625223443.2684-2-nitesh@redhat.com>
[not found] ` <3e9ce666-c9cd-391b-52b6-3471fe2be2e6@arm.com>
[not found] ` <20210127121939.GA54725@fuller.cnet>
[not found] ` <87r1m5can2.fsf@nanos.tec.linutronix.de>
[not found] ` <20210128165903.GB38339@fuller.cnet>
[not found] ` <87h7n0de5a.fsf@nanos.tec.linutronix.de>
[not found] ` <20210204181546.GA30113@fuller.cnet>
[not found] ` <cfa138e9-38e3-e566-8903-1d64024c917b@redhat.com>
[not found] ` <20210204190647.GA32868@fuller.cnet>
[not found] ` <d8884413-84b4-b204-85c5-810342807d21@redhat.com>
[not found] ` <87y2g26tnt.fsf@nanos.tec.linutronix.de>
[not found] ` <d0aed683-87ae-91a2-d093-de3f5d8a8251@redhat.com>
[not found] ` <7780ae60-efbd-2902-caaa-0249a1f277d9@redhat.com>
[not found] ` <07c04bc7-27f0-9c07-9f9e-2d1a450714ef@redhat.com>
[not found] ` <20210406102207.0000485c@intel.com>
[not found] ` <1a044a14-0884-eedb-5d30-28b4bec24b23@redhat.com>
2021-04-08 18:49 ` [Patch v4 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs Nitesh Narayan Lal
2021-04-14 16:11 ` Jesse Brandeburg
2021-04-15 22:11 ` Nitesh Narayan Lal
2021-04-29 21:44 ` Nitesh Lal
2021-04-30 1:48 ` Jesse Brandeburg
2021-04-30 13:10 ` Nitesh Lal
2021-04-30 7:10 ` Thomas Gleixner
2021-04-30 16:14 ` Nitesh Lal
2021-04-30 18:21 ` Thomas Gleixner [this message]
2021-04-30 21:07 ` Nitesh Lal
2021-05-01 2:21 ` Jesse Brandeburg
2021-05-03 13:15 ` Nitesh Lal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg37eiqa.ffs@nanos.tec.linutronix.de \
--to=tglx@linutronix$(echo .)de \
--cc=abelits@marvell$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=chris.friesen@windriver$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=frederic@kernel$(echo .)org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jinyuqi@huawei$(echo .)com \
--cc=juri.lelli@redhat$(echo .)com \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=mingo@kernel$(echo .)org \
--cc=mtosatti@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nilal@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=rppt@linux$(echo .)vnet.ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=stephen@networkplumber$(echo .)org \
--cc=zhangshaokun@hisilicon$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox