From: Vinicius Costa Gomes <vinicius.gomes@intel•com>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: netdev@vger•kernel.org, jhs@mojatatu•com,
xiyou.wangcong@gmail•com, jiri@resnulli•us,
jesus.sanchez-palencia@intel•com
Subject: Re: [RFC iproute2-next v1 5/5] tc: Add support for configuring the taprio scheduler
Date: Tue, 17 Jul 2018 09:44:02 -0700 [thread overview]
Message-ID: <87sh4h3j8t.fsf@intel.com> (raw)
In-Reply-To: <20180714121921.09af3017@shemminger-XPS-13-9360>
Hi,
Stephen Hemminger <stephen@networkplumber•org> writes:
> On Fri, 13 Jul 2018 17:06:11 -0700
> Vinicius Costa Gomes <vinicius.gomes@intel•com> wrote:
>
>> + while (fscanf(f, "%ms %x %" PRIu32 "\n", &cmd_str, &gatemask, &interval) != EOF) {
>> + struct rtattr *entry;
>> +
>> + err = str_to_entry_cmd(cmd_str);
>> + free(cmd_str);
>> +
>> + if (err < 0)
>> + return err;
>> +
>> + cmd = err;
>> +
>> + entry = addattr_nest(n, 1024, TCA_TAPRIO_SCHED_ENTRY);
>> +
>> + addattr_l(n, 1024, TCA_TAPRIO_SCHED_ENTRY_INDEX, &index, sizeof(index));
>> + addattr_l(n, 1024, TCA_TAPRIO_SCHED_ENTRY_CMD, &cmd, sizeof(cmd));
>> + addattr_l(n, 1024, TCA_TAPRIO_SCHED_ENTRY_GATE_MASK, &gatemask, sizeof(gatemask));
>> + addattr_l(n, 1024, TCA_TAPRIO_SCHED_ENTRY_INTERVAL, &interval, sizeof(interval));
>> +
>> + addattr_nest_end(n, entry);
>> + }
>> +
>
> Why not just use batch mode? Introducing another input mode in tc that is
> only in one qdisc seems like a bad idea.
Seems that I have missed batch mode. I am going to play with it a little
and see how things would look.
>
>> +
>> +static int taprio_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
>> +{
>> + struct rtattr *tb[TCA_TAPRIO_ATTR_MAX + 1];
>> + struct tc_mqprio_qopt *qopt = 0;
>> + __s64 cycle_time = 0, extension_time = 0, base_time = 0;
>> + __s32 clockid = CLOCKID_INVALID;
>> + __u32 preempt_mask = 0;
>> + int i;
>> +
>> + if (opt == NULL)
>> + return 0;
>> +
>> + parse_rtattr_nested(tb, TCA_TAPRIO_ATTR_MAX, opt);
>> +
>> + if (tb[TCA_TAPRIO_ATTR_PRIOMAP] == NULL)
>> + return -1;
>> +
>> + qopt = RTA_DATA(tb[TCA_TAPRIO_ATTR_PRIOMAP]);
>> +
>> + fprintf(f, "tc %u map ", qopt->num_tc);
>> + for (i = 0; i <= TC_PRIO_MAX; i++)
>> + fprintf(f, "%u ", qopt->prio_tc_map[i]);
>> + fprintf(f, "\n queues:");
>> + for (i = 0; i < qopt->num_tc; i++)
>> + fprintf(f, "(%u:%u) ", qopt->offset[i],
>> + qopt->offset[i] + qopt->count[i] - 1);
>> +
>> + if (tb[TCA_TAPRIO_ATTR_SCHED_CYCLE_TIME])
>> + cycle_time = rta_getattr_s64(tb[TCA_TAPRIO_ATTR_SCHED_CYCLE_TIME]);
>> +
>> + if (tb[TCA_TAPRIO_ATTR_SCHED_EXTENSION_TIME])
>> + extension_time = rta_getattr_s64(tb[TCA_TAPRIO_ATTR_SCHED_EXTENSION_TIME]);
>> +
>> + if (tb[TCA_TAPRIO_ATTR_SCHED_BASE_TIME])
>> + base_time = rta_getattr_s64(tb[TCA_TAPRIO_ATTR_SCHED_BASE_TIME]);
>> +
>> + if (tb[TCA_TAPRIO_ATTR_PREEMPT_MASK])
>> + preempt_mask = rta_getattr_s64(tb[TCA_TAPRIO_ATTR_PREEMPT_MASK]);
>> +
>> + if (tb[TCA_TAPRIO_ATTR_SCHED_CLOCKID])
>> + clockid = rta_getattr_s32(tb[TCA_TAPRIO_ATTR_SCHED_CLOCKID]);
>> +
>> + fprintf(f, "\n clockid %s ", get_clock_name(clockid));
>> +
>> + fprintf(f, "\n base-time %lld cycle-time %lld extension-time %lld ",
>> + base_time, cycle_time, extension_time);
>> +
>> + fprintf(f, "\n preempt-mask 0x%x ", preempt_mask);
>> +
>> + return print_sched_list(f, tb[TCA_TAPRIO_ATTR_SCHED_ENTRY_LIST]);
>
>
> Please implement JSON output using json_print functions.
Sure. Will do.
Cheers,
next prev parent reply other threads:[~2018-07-17 17:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-14 0:06 [RFC iproute2-next v1 0/5] net/sched: Introduce the taprio scheduler Vinicius Costa Gomes
2018-07-14 0:06 ` [RFC iproute2-next v1 1/5] utils: Implement get_s64() Vinicius Costa Gomes
2018-07-14 0:06 ` [RFC iproute2-next v1 2/5] include: Add helper to retrieve a __s64 from a netlink msg Vinicius Costa Gomes
2018-07-14 0:06 ` [RFC iproute2-next v1 3/5] libnetlink: Add helper for getting a __s32 from netlink msgs Vinicius Costa Gomes
2018-07-14 0:06 ` [RFC iproute2-next v1 4/5] include: add definitions for taprio [DO NOT COMMIT] Vinicius Costa Gomes
2018-07-14 0:06 ` [RFC iproute2-next v1 5/5] tc: Add support for configuring the taprio scheduler Vinicius Costa Gomes
2018-07-14 19:19 ` Stephen Hemminger
2018-07-17 16:44 ` Vinicius Costa Gomes [this message]
2018-07-24 23:20 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh4h3j8t.fsf@intel.com \
--to=vinicius.gomes@intel$(echo .)com \
--cc=jesus.sanchez-palencia@intel$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox