From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org>
To: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public•gmane.org>
Cc: kstewart-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public•gmane.org,
johannes.berg-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org,
tiwai-l3A5Bk7waGM@public•gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public•gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
andrew.zaborowski-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org,
Jia-Ju Bai <baijiaju1990-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public•gmane.org
Subject: Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post
Date: Mon, 08 Jan 2018 19:06:24 +0200 [thread overview]
Message-ID: <87shbg2sbz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <fc3e2558-c31f-289d-8413-33fef4f5ca64-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org> (Larry Finger's message of "Mon, 8 Jan 2018 10:31:56 -0600")
Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public•gmane.org> writes:
> On 01/08/2018 10:21 AM, Kalle Valo wrote:
>> Jia-Ju Bai <baijiaju1990-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org> wrote:
>>
>>> b43_radio_2057_init_post is not called in an interrupt handler
>>> nor holding a spinlock.
>>> The function mdelay in it can be replaced with msleep, to reduce busy wait.
>>>
>>> Signed-off-by: Jia-Ju Bai <baijiaju1990-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
>>
>> You submitted an identical patch a week earlier:
>>
>> https://patchwork.kernel.org/patch/10137671/
>>
>> How is this different? Also always add version number to the patch so that the
>> maintainers can follow the changes easily:
>>
>> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing
>>
>> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
>
> I had negative comments on one of those due to the possibility of
> msleep(2) extending as long as 20 msec. Until the author, or someone
> else, can test that this is OK, then the mdelay(2) can only be
> replaced with usleep_range(2000, 3000).
>
> NACK for both.
Ok, patches dropped.
--
Kalle Valo
next prev parent reply other threads:[~2018-01-08 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-30 11:08 [PATCH] b43: Replace mdelay with msleep in b43_radio_2057_init_post Jia-Ju Bai
2017-12-30 18:49 ` Larry Finger
2018-01-08 16:21 ` Kalle Valo
[not found] ` <1514632107-14698-1-git-send-email-baijiaju1990-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-08 16:21 ` Kalle Valo
2018-01-08 16:31 ` Larry Finger
[not found] ` <fc3e2558-c31f-289d-8413-33fef4f5ca64-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2018-01-08 17:06 ` Kalle Valo [this message]
2018-01-09 1:36 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shbg2sbz.fsf@kamboji.qca.qualcomm.com \
--to=kvalo-sgv2jx0feol9jmxxk+q4oq@public$(echo .)gmane.org \
--cc=Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public$(echo .)gmane.org \
--cc=andrew.zaborowski-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public$(echo .)gmane.org \
--cc=baijiaju1990-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public$(echo .)gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public$(echo .)gmane.org \
--cc=johannes.berg-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=kstewart-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=tiwai-l3A5Bk7waGM@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox