From: Hannes Frederic Sowa <hannes@stressinduktion•org>
To: Saeed Mahameed <saeedm@dev•mellanox.co.il>
Cc: Saeed Mahameed <saeedm@mellanox•com>,
"David S. Miller" <davem@davemloft•net>,
Linux Netdev List <netdev@vger•kernel.org>
Subject: Re: [pull request][net-next 0/3] Mellanox, mlx5 GRE tunnel offloads
Date: Mon, 04 Sep 2017 11:37:21 +0200 [thread overview]
Message-ID: <87shg2by9a.fsf@stressinduktion.org> (raw)
In-Reply-To: <CALzJLG-KgwRXODJ8BghrYzhdQYtwEM1N1UVwsg+49UiAWbb8uQ@mail.gmail.com> (Saeed Mahameed's message of "Sat, 2 Sep 2017 21:07:10 -0700")
Hello,
Saeed Mahameed <saeedm@dev•mellanox.co.il> writes:
[...]
> On Sat, Sep 2, 2017 at 6:32 PM, Hannes Frederic Sowa
> <hannes@stressinduktion•org> wrote:
>> Sorry, I think I am still confused.
>>
>> I just want to make sure that you don't use the first nibble after the
>> mpls bottom of stack label in any way as an indicator if that is an IPv4
>> or IPv6 packet by default. It can be anything. The forward equivalence
>> class tells the stack which protocol you see.
>>
>> If you match on the first nibble behind the MPLS bottom of stack label
>> the '4' or '6' respectively could be part of a MAC address with its
>> first nibble being 4 or 6, because the particular pseudowire is EoMPLS
>> and uses no control world.
>>
>> I wanted to mention it, because with addition of e.g. VPLS this could
>> cause problems down the road and should at least be controllable? It is
>> probably better to use Entropy Labels in future.
>>
>
> Hi Hannes,
>
> I see your concern now, but still it has nothing to do with the
> driver, the whole change is only to simplify driver code to not push
> full blown matching steering rules into the HW, and simply replace it
> with a one bit command.
Sorry, I very much got the impression from the cover letter plus the
descriptions of the patches.
> Regarding your concern, I will need to check with the HW guys and
> review the processing algorithm that identifies IP packets over MPLs,
> and will get back to you.
>
> if there is really a problem, then yes, we might need to make it
> controllable ..
Thanks for looking into this. I do think it can be added as a feature
but I very much think such logic should be disabled by default.
Thanks,
Hannes
prev parent reply other threads:[~2017-09-04 9:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 23:04 [pull request][net-next 0/3] Mellanox, mlx5 GRE tunnel offloads Saeed Mahameed
2017-08-30 23:04 ` [net-next 1/3] net/mlx5e: Use IP version matching to classify IP traffic Saeed Mahameed
2017-08-30 23:04 ` [net-next 2/3] net/mlx5e: Support TSO and TX checksum offloads for GRE tunnels Saeed Mahameed
2017-08-30 23:04 ` [net-next 3/3] net/mlx5e: Support RSS for GRE tunneled packets Saeed Mahameed
2017-08-31 5:15 ` [pull request][net-next 0/3] Mellanox, mlx5 GRE tunnel offloads David Miller
2017-08-31 13:51 ` Hannes Frederic Sowa
2017-09-02 23:01 ` Saeed Mahameed
2017-09-03 1:32 ` Hannes Frederic Sowa
2017-09-03 1:37 ` Tom Herbert
2017-09-03 4:11 ` Saeed Mahameed
2017-09-03 15:43 ` Tom Herbert
2017-09-03 16:17 ` Or Gerlitz
2017-09-03 16:45 ` Tom Herbert
2017-09-03 18:58 ` Or Gerlitz
2017-09-04 13:50 ` Hannes Frederic Sowa
2017-09-04 16:15 ` Tom Herbert
2017-09-04 16:52 ` Hannes Frederic Sowa
2017-09-04 17:11 ` Tom Herbert
2017-09-04 17:57 ` Hannes Frederic Sowa
2017-09-04 18:56 ` Tom Herbert
2017-09-05 11:14 ` Hannes Frederic Sowa
2017-09-05 16:02 ` Tom Herbert
2017-09-05 19:20 ` Hannes Frederic Sowa
2017-09-05 21:13 ` Tom Herbert
2017-09-06 3:06 ` Alexander Duyck
2017-09-06 16:17 ` Tom Herbert
2017-09-06 17:43 ` Alexander Duyck
2017-09-06 19:01 ` Tom Herbert
2017-09-03 4:07 ` Saeed Mahameed
2017-09-04 9:37 ` Hannes Frederic Sowa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shg2by9a.fsf@stressinduktion.org \
--to=hannes@stressinduktion$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saeedm@dev$(echo .)mellanox.co.il \
--cc=saeedm@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox