From: Hannes Frederic Sowa <hannes@stressinduktion•org>
To: Tom Herbert <tom@quantonium•net>
Cc: netdev@vger•kernel.org, rohit@quantonium•net, davejwatson@fb•com,
john.fastabend@gmail•com
Subject: Re: [PATCH v3 net-next 3/5] sock: ULP infrastructure
Date: Tue, 08 Aug 2017 12:38:58 -0400 [thread overview]
Message-ID: <87shh2t3od.fsf@stressinduktion.org> (raw)
In-Reply-To: <20170807172818.31855-4-tom@quantonium.net> (Tom Herbert's message of "Mon, 7 Aug 2017 10:28:16 -0700")
Tom Herbert <tom@quantonium•net> writes:
> +#ifdef CONFIG_MODULES
> + if (!ulp && capable(CAP_NET_ADMIN)) {
> + rcu_read_unlock();
> + request_module("%s", name);
> + rcu_read_lock();
> + ulp = ulp_find(name);
> + }
> +#endif
It looks to me that this allows users with only CAP_NET_ADMIN
privileges to load every module?
next prev parent reply other threads:[~2017-08-08 16:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 17:28 [PATCH v3 net-next 0/5] ulp: Generalize ULP infrastructure Tom Herbert
2017-08-07 17:28 ` [PATCH v3 net-next 1/5] proto_ops: Fixes to adding locked version of sendmsg/page Tom Herbert
2017-08-08 9:55 ` John Fastabend
2017-08-07 17:28 ` [PATCH v3 net-next 2/5] inet: include net/sock.h in inet_common.h Tom Herbert
2017-08-07 17:28 ` [PATCH v3 net-next 3/5] sock: ULP infrastructure Tom Herbert
2017-08-08 10:16 ` John Fastabend
2017-08-08 16:38 ` Hannes Frederic Sowa [this message]
2017-08-08 17:07 ` Tom Herbert
2017-08-07 17:28 ` [PATCH v3 net-next 4/5] tcp: Adjust TCP ULP to defer to sockets ULP Tom Herbert
2017-08-08 19:37 ` John Fastabend
2017-08-07 17:28 ` [PATCH v3 net-next 5/5] ulp: Documention for ULP infrastructure Tom Herbert
2017-08-08 15:31 ` [PATCH v3 net-next 0/5] ulp: Generalize " John Fastabend
2017-08-08 15:38 ` John Fastabend
2017-08-08 17:04 ` Tom Herbert
2017-08-08 19:30 ` John Fastabend
2017-08-08 19:50 ` Tom Herbert
2017-08-08 20:23 ` Edward Cree
2017-08-08 21:08 ` Tom Herbert
2017-08-09 1:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shh2t3od.fsf@stressinduktion.org \
--to=hannes@stressinduktion$(echo .)org \
--cc=davejwatson@fb$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rohit@quantonium$(echo .)net \
--cc=tom@quantonium$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox