From: ebiederm@xmission•com (Eric W. Biederman)
To: David Miller <davem@davemloft•net>
Cc: luto@amacapital•net, security@kernel•org,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH 0/2] Rename nsproxy.pid_ns and fix a related security bug
Date: Mon, 26 Aug 2013 18:03:57 -0700 [thread overview]
Message-ID: <87sixwlzb6.fsf@xmission.com> (raw)
In-Reply-To: <20130826.155909.1859861206590524940.davem@davemloft.net> (David Miller's message of "Mon, 26 Aug 2013 15:59:09 -0400 (EDT)")
David Miller <davem@davemloft•net> writes:
> From: Andy Lutomirski <luto@amacapital•net>
> Date: Thu, 22 Aug 2013 11:39:14 -0700
>
>> commit 92f28d973cce45ef5823209aab3138eb45d8b349
>> Author: Eric W. Biederman <ebiederm@xmission•com>
>> Date: Fri Mar 15 01:03:33 2013 -0700
>>
>> scm: Require CAP_SYS_ADMIN over the current pidns to spoof pids.
>>
>> Eric fell for my bogus claim that nsproxy->pid_ns was the current'
>> process's pid ns. This isn't true.
>>
>> Let's fix the bug and rename pid_ns so that no one gets this wrong again.
>>
>> Signed-off-by: Andy Lutomirski <luto@amacapital•net>
>
> Eric please take the time to review these changes, thanks.
Reviewed they are good.
My apologies for the delay life got in my way and I fell behind on
dealing with patches.
Eric
next prev parent reply other threads:[~2013-08-27 1:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 18:39 [PATCH 0/2] Rename nsproxy.pid_ns and fix a related security bug Andy Lutomirski
2013-08-22 18:39 ` [PATCH 1/2] net: Check the correct namespace when spoofing pid over SCM_RIGHTS Andy Lutomirski
2013-08-27 1:02 ` Eric W. Biederman
2013-08-22 18:39 ` [PATCH 2/2] Rename nsproxy.pid_ns to nsproxy.pid_ns_for_children Andy Lutomirski
2013-08-22 18:56 ` Oleg Nesterov
2013-08-27 1:02 ` Eric W. Biederman
2013-08-26 19:59 ` [PATCH 0/2] Rename nsproxy.pid_ns and fix a related security bug David Miller
2013-08-27 1:03 ` Eric W. Biederman [this message]
2013-08-27 17:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sixwlzb6.fsf@xmission.com \
--to=ebiederm@xmission$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=luto@amacapital$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=security@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox