From: Anna-Maria Behnsen <anna-maria@linutronix•de>
To: Pavel Machek <pavel@ucw•cz>, Thomas Gleixner <tglx@linutronix•de>,
Greg KH <greg@kroah•com>
Cc: Jakub Kicinski <kuba@kernel•org>,
Jinjie Ruan <ruanjinjie@huawei•com>,
bryan.whitehead@microchip•com, davem@davemloft•net,
edumazet@google•com, pabeni@redhat•com, frederic@kernel•org,
richardcochran@gmail•com, johnstul@us•ibm.com,
UNGLinuxDriver@microchip•com, jstultz@google•com,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v5 RESEND 1/2] posix-clock: Fix missing timespec64 check in pc_clock_settime()
Date: Tue, 22 Oct 2024 16:31:33 +0200 [thread overview]
Message-ID: <87ttd45hve.fsf@somnus> (raw)
In-Reply-To: <ZxeLMu1Hy2VCqzJ6@duo.ucw.cz>
Pavel Machek <pavel@ucw•cz> writes:
> Hi!
>
>> >> > I'm guessing we can push this into 6.12-rc and the other patch into
>> >> > net-next. I'll toss it into net on Monday unless someone objects.
>> >>
>> >> Can you folks please at least wait until the maintainers of the code in
>> >> question had a look ?
>> >
>> > You are literally quoting the text where I say I will wait 3 more days.
>> > Unfortunately "until the maintainers respond" leads to waiting forever
>> > 50% of the time, and even when we cap at 3 working days we have 300
>> > patches in the queue (292 right now, and I already spent 2 hours
>> > reviewing today). Hope you understand.
>>
>> I understand very well, but _I_ spent the time to review the earlier
>> variants of these patches and to debate with the submitter up to rev
>> 5.
>>
>> Now you go and apply a patch to a subsystem you do not even maintain just
>> because I did not have the bandwidth to look at it within the time
>> limit you defined? Seriously?
>>
>> This problem is there for years, so a few days +/- are absolutely not
>> relevant.
>>
>> > Sorry if we applied too early, please review, I'll revert if it's no
>> > good.
>
> It is no good :-( and it is now in stable.
>
> It needs to goto out in the error case, to permit cleanups.
The check needs to be done before taking the lock. There is already a
patch around which solves it:
https://lore.kernel.org/r/20241018100748.706462-1-ruanjinjie@huawei.com/
Thanks,
Anna-Maria
next prev parent reply other threads:[~2024-10-22 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 7:23 [PATCH v5 RESEND 0/2] posix-clock: Fix missing timespec64 check for PTP clock Jinjie Ruan
2024-10-09 7:23 ` [PATCH v5 RESEND 1/2] posix-clock: Fix missing timespec64 check in pc_clock_settime() Jinjie Ruan
2024-10-11 19:57 ` Jakub Kicinski
2024-10-15 22:33 ` Thomas Gleixner
2024-10-15 23:22 ` Jakub Kicinski
2024-10-16 14:52 ` Thomas Gleixner
2024-10-22 11:23 ` Pavel Machek
2024-10-22 14:31 ` Anna-Maria Behnsen [this message]
2024-10-09 7:23 ` [PATCH v5 RESEND 2/2] net: lan743x: Remove duplicate check Jinjie Ruan
2024-10-15 0:40 ` [PATCH v5 RESEND 0/2] posix-clock: Fix missing timespec64 check for PTP clock patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttd45hve.fsf@somnus \
--to=anna-maria@linutronix$(echo .)de \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=bryan.whitehead@microchip$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=frederic@kernel$(echo .)org \
--cc=greg@kroah$(echo .)com \
--cc=johnstul@us$(echo .)ibm.com \
--cc=jstultz@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavel@ucw$(echo .)cz \
--cc=richardcochran@gmail$(echo .)com \
--cc=ruanjinjie@huawei$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox