Subject: Re: [patch net-next v3 6/6] selftests: virtio_net: add initial tests

From: Petr Machata <[email-masked]>
Date: Thu, 18 Apr 2024 10:39:49 +0200

Jiri Pirko <[email-masked]> writes:

> From: Jiri Pirko <[email-masked]>
>
> Introduce initial tests for virtio_net driver. Focus on feature testing
> leveraging previously introduced debugfs feature filtering
> infrastructure. Add very basic ping and F_MAC feature tests.
>
> To run this, do:
> $ make -C tools/testing/selftests/ TARGETS=drivers/net/virtio_net/ run_tests
>
> Run it on a system with 2 virtio_net devices connected back-to-back
> on the hypervisor.
>
> Signed-off-by: Jiri Pirko <[email-masked]>

> +h2_destroy()
> +{
> +	simple_if_fini $h2 $H2_IPV4/24 $H2_IPV6/64
> +}
> +
> +initial_ping_test()
> +{
> +	cleanup

All these cleanup() calls will end up possibly triggering
PAUSE_ON_CLEANUP. Not sure that's intended.

> +	setup_prepare
> +	ping_test $h1 $H2_IPV4 " simple"
> +}

Other than this nit, LGTM.

Reviewed-by: Petr Machata <[email-masked]>