Subject: Re: [PATCH net-next 3/5] ethtool: add interface to read representor Rx statistics

From: Rahul Rameshbabu <[email-masked]>
Date: Fri, 05 Apr 2024 22:25:21 -0700

On Fri, 05 Apr, 2024 21:53:35 -0700 Jakub Kicinski <[email-masked]> wrote:
> On Thu, 4 Apr 2024 20:33:55 +0300 Tariq Toukan wrote:
>> +/**
>> + * struct ethtool_rep_port_stats - representor port statistics
>> + * @rep_port_stats: struct group for representor port
>
> In more trivial remarks - kernel-doc script apparently doesn't want
> the group to be documented (any more?)
>

I took a look, and I believe the behavior of kernel-doc has remained the
same since the struct_group() helper macro was introduced. That said, I
think allowing the documentation of struct_group() would be a reasonable
choice/maybe worth updating the script.

  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=50d7bd38c3aafc4749e05e8d7fcb616979143602

>> + *	@out_of_buf: Number of packets were dropped due to buffer exhaustion.
>> + */
>> +struct ethtool_rep_port_stats {
>> +	struct_group(rep_port_stats,
>> +		u64 out_of_buf;
>> +	);
>> +};
>> +