From: "Toke Høiland-Jørgensen" <toke@toke•dk>
To: Jakub Kicinski <jakub.kicinski@netronome•com>
Cc: netdev@vger•kernel.org, Jesper Dangaard Brouer <brouer@redhat•com>
Subject: Re: [PATCH bpf-next v5 1/2] trace_helpers.c: Add helpers to poll multiple perf FDs for events
Date: Wed, 06 Jun 2018 19:51:15 +0200 [thread overview]
Message-ID: <87tvqfercc.fsf@toke.dk> (raw)
In-Reply-To: <20180606095522.362afa4d@cakuba.netronome.com>
Jakub Kicinski <jakub.kicinski@netronome•com> writes:
> On Wed, 06 Jun 2018 14:43:39 +0200, Toke Høiland-Jørgensen wrote:
>> Add two new helper functions to trace_helpers that supports polling
>> multiple perf file descriptors for events. These are used to the XDP
>> perf_event_output example, which needs to work with one perf fd per CPU.
>>
>> Signed-off-by: Toke Høiland-Jørgensen <toke@toke•dk>
>
> malloc() + memset(0) could have been replaced with calloc, but
> otherwise looks good.
Ah right. I'll fix that and your nit for the other patch and resubmit
with your reviewed-by tag. Thanks for reviewing!
next prev parent reply other threads:[~2018-06-06 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 12:43 [PATCH bpf-next v5 1/2] trace_helpers.c: Add helpers to poll multiple perf FDs for events Toke Høiland-Jørgensen
2018-06-06 12:43 ` [PATCH bpf-next v5 2/2] samples/bpf: Add xdp_sample_pkts example Toke Høiland-Jørgensen
2018-06-06 16:54 ` Jakub Kicinski
2018-06-06 16:55 ` [PATCH bpf-next v5 1/2] trace_helpers.c: Add helpers to poll multiple perf FDs for events Jakub Kicinski
2018-06-06 17:51 ` Toke Høiland-Jørgensen [this message]
2018-06-06 20:17 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvqfercc.fsf@toke.dk \
--to=toke@toke$(echo .)dk \
--cc=brouer@redhat$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox