From: Kalle Valo <kvalo@codeaurora•org>
To: Javier Martinez Canillas <javier@osg•samsung.com>
Cc: linux-kernel@vger•kernel.org,
Amitkumar Karwar <akarwar@marvell•com>,
netdev@vger•kernel.org, linux-wireless@vger•kernel.org,
Nishant Sarmukadam <nishants@marvell•com>
Subject: Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback
Date: Tue, 05 Jul 2016 16:09:26 +0300 [thread overview]
Message-ID: <87twg42pvd.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1467401982-18943-1-git-send-email-javier@osg.samsung.com> (Javier Martinez Canillas's message of "Fri, 1 Jul 2016 15:39:42 -0400")
Javier Martinez Canillas <javier@osg•samsung.com> writes:
> The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added
> interface") attempted to fix an issue when a new AP interface is added.
>
> But the patch didn't check the return value of the functions doing the
> firmware calls and returned an error even if the functions didn't fail.
>
> This prevents the network device to be registered properly, so fix it.
>
> Fixes: commit 7311ea850079 ("mwifiex: fix AP start problem for newly added interface")
> Signed-off-by: Javier Martinez Canillas <javier@osg•samsung.com>
The fixes line should be:
Fixes: 7311ea850079 ("mwifiex: fix AP start problem for newly added interface")
I can fix that before I apply the patch.
--
Kalle Valo
next prev parent reply other threads:[~2016-07-05 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 19:39 [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback Javier Martinez Canillas
2016-07-04 0:18 ` Julian Calaby
2016-07-05 13:09 ` Kalle Valo [this message]
2016-07-05 13:14 ` Javier Martinez Canillas
2016-07-05 13:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twg42pvd.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora$(echo .)org \
--cc=akarwar@marvell$(echo .)com \
--cc=javier@osg$(echo .)samsung.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nishants@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox