Subject: Re: [PATCH v7 03/33] net: set name_assign_type in alloc_netdev()

From: Bjørn Mork <[email-masked]>
Date: Thu, 10 Jul 2014 11:16:50 +0200

Tom Gundersen <[email-masked]> writes:

> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
> index 5dc638c..f405e05 100644
> --- a/net/ethernet/eth.c
> +++ b/net/ethernet/eth.c
> @@ -390,7 +390,8 @@ EXPORT_SYMBOL(ether_setup);
>  struct net_device *alloc_etherdev_mqs(int sizeof_priv, unsigned int txqs,
>  				      unsigned int rxqs)
>  {
> -	return alloc_netdev_mqs(sizeof_priv, "eth%d", ether_setup, txqs, rxqs);
> +	return alloc_netdev_mqs(sizeof_priv, "eth%d", NET_NAME_UNKNOWN,
> +				ether_setup, txqs, rxqs);
>  }
>  EXPORT_SYMBOL(alloc_etherdev_mqs);

I believe this chunk makes the rest of this exercise pretty pointless.

bjorn@nemi:/usr/local/src/git/linux$ git grep alloc_etherdev drivers/net/|wc -l
283

I don't care enough to go look, but I'd be surprised if none of those
drivers rename the device before registering it.

Bjørn