From: Rusty Russell <rusty@rustcorp•com.au>
To: Amit Shah <amit.shah@redhat•com>, "Michael S. Tsirkin" <mst@redhat•com>
Cc: netdev <netdev@vger•kernel.org>,
linux-pm@vger•kernel.org, linux-kernel@vger•kernel.org,
Virtualization List <virtualization@lists•linux-foundation.org>
Subject: Re: [PATCH v6 09/11] virtio: net: Add freeze, restore handlers to support S4
Date: Wed, 04 Jan 2012 13:19:47 +1030 [thread overview]
Message-ID: <87ty4cchbo.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120103170748.GE4536@amit.redhat.com>
On Tue, 3 Jan 2012 22:37:48 +0530, Amit Shah <amit.shah@redhat•com> wrote:
> On (Sun) 01 Jan 2012 [13:47:27], Michael S. Tsirkin wrote:
> > On Fri, Dec 30, 2011 at 03:08:19PM +0530, Amit Shah wrote:
> > > >
> > > > > + if (!try_fill_recv(vi, GFP_KERNEL))
> > > > > + schedule_delayed_work(&vi->refill, 0);
> > > >
> > > > This needs to be switched to non reentrant wq too?
> > >
> > > Subsequent invocations could create problems? Note that this will be
> > > the first item to be queued in the workqueue for the refill work.
> > >
> > > Amit
> >
> > See recent patches on net-next.
> > We switched other calls to a non reentrant wq so I think same
> > reasoning applies there.
>
> There's a patch ordering issue; so this series should land after the
> -net series is merged.
>
> Rusty, do you want me to re-spin this patch on top of yours, or is
> that something that you'll handle?
Indeed, this can't go via -net, since it needs the virtio-pci patches
which change power management.
I've changed that one line, and will post those patches for DaveM's ack.
Thanks,
Rusty.
parent reply other threads:[~2012-01-04 2:49 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20120103170748.GE4536@amit.redhat.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ty4cchbo.fsf@rustcorp.com.au \
--to=rusty@rustcorp$(echo .)com.au \
--cc=amit.shah@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox