From: Kalle Valo <kvalo@codeaurora•org>
To: Niklas Cassel <niklas.cassel@linaro•org>
Cc: alagusankar@silex-india•com, netdev@vger•kernel.org,
linux-wireless@vger•kernel.org, linux-kernel@vger•kernel.org,
ath10k@lists•infradead.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH 1/3] ath10k: sdio: use same endpoint id for all packets in a bundle
Date: Fri, 29 Jun 2018 14:53:44 +0300 [thread overview]
Message-ID: <87vaa1erlj.fsf@codeaurora.org> (raw)
In-Reply-To: <87zhzdersm.fsf@codeaurora.org> (Kalle Valo's message of "Fri, 29 Jun 2018 14:49:29 +0300")
Kalle Valo <kvalo@codeaurora•org> writes:
> Niklas Cassel <niklas.cassel@linaro•org> writes:
>
>> All packets in a bundle should use the same endpoint id as the
>> first lookahead.
>>
>> This matches how things are done is ath6kl, however,
>> this patch can theoretically handle several bundles
>> in ath10k_sdio_mbox_rx_process_packets().
>>
>> Without this patch we get lots of errors about invalid endpoint id:
>>
>> ath10k_sdio mmc2:0001:1: invalid endpoint in look-ahead: 224
>> ath10k_sdio mmc2:0001:1: failed to get pending recv messages: -12
>> ath10k_sdio mmc2:0001:1: failed to process pending SDIO interrupts: -12
>>
>> Signed-off-by: Alagu Sankar <alagusankar@silex-india•com>
>> Signed-off-by: Niklas Cassel <niklas.cassel@linaro•org>
>
> You have Alagu's s-o-b first so that implies Alagu is the author. So
> should I add From header for Alagu and add you (Niklas) as
> Co-Developed-by? Or vice versa?
Ah, the same issue is with all three patches. So whatever we decide,
I'll do the same changes on all three.
--
Kalle Valo
next prev parent reply other threads:[~2018-06-29 11:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 8:42 [PATCH 0/3] ath10k: sdio: essential sdio fixes Niklas Cassel
2018-06-20 8:42 ` [PATCH 1/3] ath10k: sdio: use same endpoint id for all packets in a bundle Niklas Cassel
2018-06-29 11:49 ` Kalle Valo
2018-06-29 11:53 ` Kalle Valo [this message]
2018-06-29 13:11 ` Niklas Cassel
2018-06-29 13:51 ` Kalle Valo
2018-06-29 13:56 ` Niklas Cassel
2018-07-02 14:23 ` [1/3] " Kalle Valo
2018-07-02 14:23 ` Kalle Valo
2018-06-20 8:42 ` [PATCH 2/3] ath10k: sdio: allocate correct size for RECV_1MORE_BLOCK rx packets Niklas Cassel
2018-06-20 8:42 ` [PATCH 3/3] ath10k: sdio: set skb len for all " Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaa1erlj.fsf@codeaurora.org \
--to=kvalo@codeaurora$(echo .)org \
--cc=alagusankar@silex-india$(echo .)com \
--cc=ath10k@lists$(echo .)infradead.org \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=niklas.cassel@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox